Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 23600041: Add tests for recent popup blocker fixes (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add tests for recent popup blocker fixes Check that the renderer can't launch a denial of service attack on the browser Check that the content settings apply to the main frame URL BUG=289528, 289525 R=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223300

Patch Set 1 #

Total comments: 4

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 2 chunks +45 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-dos.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-frames.html View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-frames-iframe.html View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-12 13:18:20 UTC) #1
jochen (gone - plz use gerrit)
plz review
7 years, 3 months ago (2013-09-12 13:30:39 UTC) #2
Bernhard Bauer
LGTM w/ some nits: https://codereview.chromium.org/23600041/diff/1/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc File chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (right): https://codereview.chromium.org/23600041/diff/1/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc#newcode267 chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:267: GURL frame_url(ui_test_utils::GetTestUrl( Nit: You could ...
7 years, 3 months ago (2013-09-12 13:39:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/23600041/10001
7 years, 3 months ago (2013-09-15 20:26:22 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 02:45:40 UTC) #5
Message was sent while issue was closed.
Change committed as 223300

Powered by Google App Engine
This is Rietveld 408576698