Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(178)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/popup_blocker/popup-frames-iframe.html
Issue
23600041
:
Add tests for recent popup blocker fixes (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates
Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
chrome/test/data/popup_blocker/popup-dos.html
chrome/test/data/popup_blocker/popup-frames.html
chrome/test/data/popup_blocker/popup-frames-iframe.html
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« chrome/test/data/popup_blocker/popup-frames.html
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<html>
3
<head>
4
<title>iframe that opens a poup</title>
5
<script>
6
function test() {
7
window.open("about:blank");
8
}
9
</script>
10
</head>
11
<body onload="test()">
12
</body>
13
</html>
OLD
NEW
« no previous file with comments
|
« chrome/test/data/popup_blocker/popup-frames.html
('k') |
no next file »
|
no next file with comments »
Issue 23600041: Add tests for recent popup blocker fixes (Closed)
Created 7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified 7 years, 3 months ago
Reviewers: Bernhard Bauer
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 4
This is Rietveld
408576698