Add a button to OIB to launch an instant app if it exists.

Add a button to OIB to launch an instant app if it exists.

BUG=649874
Committed: https://crrev.com/8821564759581ce84eddb3845e72b17e5d41dc9e
Cr-Commit-Position: refs/heads/master@{#421278}

[Ted C, 2016-09-23 23:54:36]

tedchoc@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Ted C, 2016-09-23 23:54:37]

PTAL

[Maria, 2016-09-26 17:36:26]

lgtm

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/website_settings.xml (right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/website_settings.xml:71:
android:layout_marginBottom="4dp"
I wish I understood when @dimen is used and when it's not

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/website_settings.xml:76: android:textColor="#fff"
@color?

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:207:
this, intent, mIsCustomTabIntent)) {
does this now fit on the previous line?

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:565:
getAvailableContext(), url,
nit: move to previous line?

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:768:
mContext.startActivity(mInstantAppIntent);
Can you add a RecordUserAction("Android.InstantApps.LaunchedFromWebsitePopup")
here?

[Ted C, 2016-09-26 18:05:04]

tedchoc@chromium.org changed reviewers:
+ gayane@chromium.org

[Ted C, 2016-09-26 18:05:04]

+gayane@ for metrics

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/website_settings.xml (right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/website_settings.xml:71:
android:layout_marginBottom="4dp"
On 2016/09/26 17:36:25, Maria wrote:
> I wish I understood when @dimen is used and when it's not

For me, @dimen is for sharing, otherwise inline and make it easier to read.

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/website_settings.xml:76: android:textColor="#fff"
On 2016/09/26 17:36:25, Maria wrote:
> @color?

switched to @android:color/white

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:207:
this, intent, mIsCustomTabIntent)) {
On 2016/09/26 17:36:25, Maria wrote:
> does this now fit on the previous line?

Alas no, 103 chars

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:565:
getAvailableContext(), url,
On 2016/09/26 17:36:25, Maria wrote:
> nit: move to previous line?

Done.

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2359363004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:768:
mContext.startActivity(mInstantAppIntent);
On 2016/09/26 17:36:26, Maria wrote:
> Can you add a RecordUserAction("Android.InstantApps.LaunchedFromWebsitePopup")
> here?

Done.

[gayane -on leave until 09-2017, 2016-09-27 17:18:30]

lgtm

[Ted C, 2016-09-27 17:20:00]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2016-09-27 17:20:00]

+dfalcantara for infobar OWNERS

[gone, 2016-09-27 17:25:40]

lgtm

[Maria, 2016-09-27 18:00:22]

The CQ bit was checked by mariakhomenko@chromium.org

[Maria, 2016-09-27 18:00:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2359363004/#ps40001
(title: "Comments")

[commit-bot: I haz the power, 2016-09-27 18:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:35:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 18:38:56]

Description was changed from

==========
Add a button to OIB to launch an instant app if it exists.

BUG=649874
==========

to

==========
Add a button to OIB to launch an instant app if it exists.

BUG=649874

Committed: https://crrev.com/8821564759581ce84eddb3845e72b17e5d41dc9e
Cr-Commit-Position: refs/heads/master@{#421278}
==========

[commit-bot: I haz the power, 2016-09-27 18:38:59]

Patchset 3 (id:??) landed as
https://crrev.com/8821564759581ce84eddb3845e72b17e5d41dc9e
Cr-Commit-Position: refs/heads/master@{#421278}