Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java

Issue 2359363004: Add a button to OIB to launch an instant app if it exists. (Closed)
Patch Set: Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
index 8973337894de76b166d2830f4b699f89dd9948f6..7ba6e0b2fdd5476fb7e22402f4cfca2df8102d8d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
@@ -13,6 +13,7 @@ import android.provider.Browser;
import android.text.TextUtils;
import org.chromium.base.CommandLine;
+import org.chromium.base.ContextUtils;
import org.chromium.base.FieldTrialList;
import org.chromium.base.Log;
import org.chromium.base.metrics.RecordUserAction;
@@ -69,10 +70,11 @@ public class InstantAppsHandler {
private Set<String> mOptInHosts = new HashSet<>();
/** @return The singleton instance of {@link InstantAppsHandler}. */
- public static InstantAppsHandler getInstance(ChromeApplication application) {
+ public static InstantAppsHandler getInstance() {
synchronized (INSTANCE_LOCK) {
if (sInstance == null) {
- sInstance = application.createInstantAppsHandler();
+ Context appContext = ContextUtils.getApplicationContext();
+ sInstance = ((ChromeApplication) appContext).createInstantAppsHandler();
}
}
return sInstance;
@@ -128,7 +130,8 @@ public class InstantAppsHandler {
* Cache whether the Instant Apps feature is enabled.
* This should only be called with the native library loaded.
*/
- public void cacheInstantAppsEnabled(Context context) {
+ public void cacheInstantAppsEnabled() {
+ Context context = ContextUtils.getApplicationContext();
boolean isEnabled = false;
boolean wasEnabled = isEnabled(context);
CommandLine instance = CommandLine.getInstance();
@@ -269,4 +272,14 @@ public class InstantAppsHandler {
mOptInHosts.add(hostname);
// TODO(mariakhomenko): Implement persistence for optInHosts.
}
+
+ /**
+ * Gets the instant app intent for the given URL if one exists.
+ *
+ * @param url The URL whose instant app this is associated with.
+ * @return An instant app intent for the URL if one exists.
+ */
+ public Intent getInstantAppIntentForUrl(String url) {
+ return null;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698