presubmit_canned_checks.py - Issue 23591064: Change the "Missing OWNERS" presubmit check to only suggest owners for missing files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 23591064: Change the "Missing OWNERS" presubmit check to only suggest owners for missing files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index aecdd83fa50e9621f36557ba6583afd415ad0ce4..f75b9c861c670dd01baefeb5fe61840ac14c9b00 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -822,7 +822,7 @@ def CheckOwners(input_api, output_api, source_file_filter=None,

output('Missing %s for these files:\n %s' %

(needed, '\n '.join(sorted(missing_files))))]

if not input_api.is_committing:

- suggested_owners = owners_db.reviewers_for(affected_files, owner_email)

+ suggested_owners = owners_db.reviewers_for(missing_files, owner_email)

output_list.append(output('Suggested OWNERS:\n %s' %

('\n '.join(suggested_owners or []))))

return output_list

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »