OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Generic presubmit checks that can be reused by other presubmit checks.""" | 5 """Generic presubmit checks that can be reused by other presubmit checks.""" |
6 | 6 |
7 import os as _os | 7 import os as _os |
8 _HERE = _os.path.dirname(_os.path.abspath(__file__)) | 8 _HERE = _os.path.dirname(_os.path.abspath(__file__)) |
9 | 9 |
10 | 10 |
(...skipping 804 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
815 missing_files = owners_db.files_not_covered_by(affected_files, | 815 missing_files = owners_db.files_not_covered_by(affected_files, |
816 reviewers_plus_owner) | 816 reviewers_plus_owner) |
817 else: | 817 else: |
818 missing_files = owners_db.files_not_covered_by(affected_files, reviewers) | 818 missing_files = owners_db.files_not_covered_by(affected_files, reviewers) |
819 | 819 |
820 if missing_files: | 820 if missing_files: |
821 output_list = [ | 821 output_list = [ |
822 output('Missing %s for these files:\n %s' % | 822 output('Missing %s for these files:\n %s' % |
823 (needed, '\n '.join(sorted(missing_files))))] | 823 (needed, '\n '.join(sorted(missing_files))))] |
824 if not input_api.is_committing: | 824 if not input_api.is_committing: |
825 suggested_owners = owners_db.reviewers_for(affected_files, owner_email) | 825 suggested_owners = owners_db.reviewers_for(missing_files, owner_email) |
826 output_list.append(output('Suggested OWNERS:\n %s' % | 826 output_list.append(output('Suggested OWNERS:\n %s' % |
827 ('\n '.join(suggested_owners or [])))) | 827 ('\n '.join(suggested_owners or [])))) |
828 return output_list | 828 return output_list |
829 | 829 |
830 if input_api.is_committing and not reviewers: | 830 if input_api.is_committing and not reviewers: |
831 return [output('Missing LGTM from someone other than %s' % owner_email)] | 831 return [output('Missing LGTM from someone other than %s' % owner_email)] |
832 return [] | 832 return [] |
833 | 833 |
834 | 834 |
835 def _GetRietveldIssueProps(input_api, messages): | 835 def _GetRietveldIssueProps(input_api, messages): |
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1022 snapshot("checking description") | 1022 snapshot("checking description") |
1023 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 1023 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
1024 input_api, output_api)) | 1024 input_api, output_api)) |
1025 results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription( | 1025 results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription( |
1026 input_api, output_api)) | 1026 input_api, output_api)) |
1027 snapshot("checking do not submit in files") | 1027 snapshot("checking do not submit in files") |
1028 results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles( | 1028 results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles( |
1029 input_api, output_api)) | 1029 input_api, output_api)) |
1030 snapshot("done") | 1030 snapshot("done") |
1031 return results | 1031 return results |
OLD | NEW |