Issue 23591064: Change the "Missing OWNERS" presubmit check to only suggest owners for missing files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23591064: Change the "Missing OWNERS" presubmit check to only suggest owners for missing files. (Closed)

Created:
7 years, 3 months ago by Dirk Pranke

Modified:
7 years, 3 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Change the "Missing OWNERS" presubmit check to only suggest owners for missing files. Previously we would suggest owners for the whole CL, rather than just the files currently missing owner approval. R=maruel@chromium.org BUG=130978 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=224183

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/23591064/1

7 years, 3 months ago (2013-09-19 19:22:17 UTC) #3

Message was sent while issue was closed.

Change committed as 224183