Add mini_installer tests to the Chromium build infrastructure.

Add mini_installer tests to the Chromium build infrastructure.

BUG=264859
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=220214

[csharp, 2013-08-28 19:25:00]

https://codereview.chromium.org/23591008/diff/1/masters/master.chromium.fyi/m...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/23591008/diff/1/masters/master.chromium.fyi/m...
masters/master.chromium.fyi/master.cfg:151: 'Chromium Win MiniInstaller Tests',
If you can use the standard win_rel output, then you can probably move this to
the triggerable selection below (then your bot won't compile the code itself,
instead it will just get it from the win_rel bot)

https://codereview.chromium.org/23591008/diff/1/masters/master.chromium.fyi/m...
masters/master.chromium.fyi/master.cfg:657: f_cr_win_rel_miniinstaller =
win_build().ChromiumFactory(
nit: miniinstaller -> mini_installer (here and elsewhere)

https://codereview.chromium.org/23591008/diff/1/scripts/master/factory/chromi...
File scripts/master/factory/chromium_commands.py (right):

https://codereview.chromium.org/23591008/diff/1/scripts/master/factory/chromi...
scripts/master/factory/chromium_commands.py:1603: if self._target_platform ==
'win32' and self._target == 'Release':
Why this if statement? Does this test not sense in the other cases?

[sukolsak, 2013-08-28 19:46:19]

Thank you for your review.

https://codereview.chromium.org/23591008/diff/1/masters/master.chromium.fyi/m...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/23591008/diff/1/masters/master.chromium.fyi/m...
masters/master.chromium.fyi/master.cfg:151: 'Chromium Win MiniInstaller Tests',
On 2013/08/28 19:25:00, csharp wrote:
> If you can use the standard win_rel output, then you can probably move this to
> the triggerable selection below (then your bot won't compile the code itself,
> instead it will just get it from the win_rel bot)

Done.

https://codereview.chromium.org/23591008/diff/1/masters/master.chromium.fyi/m...
masters/master.chromium.fyi/master.cfg:657: f_cr_win_rel_miniinstaller =
win_build().ChromiumFactory(
On 2013/08/28 19:25:00, csharp wrote:
> nit: miniinstaller -> mini_installer (here and elsewhere)

Done.

https://codereview.chromium.org/23591008/diff/1/scripts/master/factory/chromi...
File scripts/master/factory/chromium_commands.py (right):

https://codereview.chromium.org/23591008/diff/1/scripts/master/factory/chromi...
scripts/master/factory/chromium_commands.py:1603: if self._target_platform ==
'win32' and self._target == 'Release':
On 2013/08/28 19:25:00, csharp wrote:
> Why this if statement? Does this test not sense in the other cases?

Fixed. This should also work with 64-bit builds. I only want to test it with
release builds.

[M-A Ruel, 2013-08-28 19:50:12]

https://codereview.chromium.org/23591008/diff/1005/masters/master.chromium.fy...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/23591008/diff/1005/masters/master.chromium.fy...
masters/master.chromium.fyi/master.cfg:165: 'Chromium Win MiniInstaller Tests'])
sort

https://codereview.chromium.org/23591008/diff/1005/scripts/master/factory/chr...
File scripts/master/factory/chromium_commands.py (right):

https://codereview.chromium.org/23591008/diff/1005/scripts/master/factory/chr...
scripts/master/factory/chromium_commands.py:1603: if self._target == 'Release':
Remove this, it's not needed.

If you don't want to have it run on Debug, don't list this test in the tests
list, that's all.

[Mike Stip (use stip instead), 2013-08-28 21:02:27]

address maurel's comments, then lg2m

[sukolsak, 2013-08-29 00:05:49]

Add mini_installer tests to the Chromium build infrastructure.

[sukolsak, 2013-08-29 00:07:48]

Thank you for your review.

https://codereview.chromium.org/23591008/diff/1005/masters/master.chromium.fy...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/23591008/diff/1005/masters/master.chromium.fy...
masters/master.chromium.fyi/master.cfg:165: 'Chromium Win MiniInstaller Tests'])
On 2013/08/28 19:50:12, M-A Ruel wrote:
> sort

Done.

https://codereview.chromium.org/23591008/diff/1005/scripts/master/factory/chr...
File scripts/master/factory/chromium_commands.py (right):

https://codereview.chromium.org/23591008/diff/1005/scripts/master/factory/chr...
scripts/master/factory/chromium_commands.py:1603: if self._target == 'Release':
On 2013/08/28 19:50:12, M-A Ruel wrote:
> Remove this, it's not needed.
> 
> If you don't want to have it run on Debug, don't list this test in the tests
> list, that's all.

Done.

[Mike Stip (use stip instead), 2013-08-29 00:13:33]

lgtm

[robertshield, 2013-08-29 00:45:01]

https://codereview.chromium.org/23591008/diff/11001/scripts/master/factory/ch...
File scripts/master/factory/chromium_commands.py (right):

https://codereview.chromium.org/23591008/diff/11001/scripts/master/factory/ch...
scripts/master/factory/chromium_commands.py:103: self._mini_installer_tests =
J('src', 'chrome', 'test', 'mini_installer',
nit: s/_mini_installer_tests/_mini_installer_tests_config

https://codereview.chromium.org/23591008/diff/11001/scripts/master/factory/ch...
scripts/master/factory/chromium_commands.py:1605:
self.AddTestStep(chromium_step.AnnotatedCommand, 'test_mini_installer', cmd,
question: does AnnotatedCommand like / correctly parse the test output?

[sukolsak, 2013-08-29 07:38:54]

Thanks for your review.

https://codereview.chromium.org/23591008/diff/11001/scripts/master/factory/ch...
File scripts/master/factory/chromium_commands.py (right):

https://codereview.chromium.org/23591008/diff/11001/scripts/master/factory/ch...
scripts/master/factory/chromium_commands.py:103: self._mini_installer_tests =
J('src', 'chrome', 'test', 'mini_installer',
On 2013/08/29 00:45:01, robertshield wrote:
> nit: s/_mini_installer_tests/_mini_installer_tests_config

Done.

https://codereview.chromium.org/23591008/diff/11001/scripts/master/factory/ch...
scripts/master/factory/chromium_commands.py:1605:
self.AddTestStep(chromium_step.AnnotatedCommand, 'test_mini_installer', cmd,
On 2013/08/29 00:45:01, robertshield wrote:
> question: does AnnotatedCommand like / correctly parse the test output?

I am not sure. As discussed, let's submit it to find out.

[commit-bot: I haz the power, 2013-08-29 07:40:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23591008/22001

[commit-bot: I haz the power, 2013-08-29 07:41:20]

Change committed as 220214

[Nico, 2013-12-14 00:21:39]

https://chromiumcodereview.appspot.com/23591008/diff/22001/scripts/master/fac...
File scripts/master/factory/chromium_commands.py (right):

https://chromiumcodereview.appspot.com/23591008/diff/22001/scripts/master/fac...
scripts/master/factory/chromium_commands.py:105: 'config.config')
Do you intend to have several configs in the future? Why doesn't test_install.py
just pick up the config from config/config.config relative to itself?

[robertshield, 2014-01-23 20:35:50]

@Nico:

https://chromiumcodereview.appspot.com/23591008/diff/22001/scripts/master/fac...
File scripts/master/factory/chromium_commands.py (right):

https://chromiumcodereview.appspot.com/23591008/diff/22001/scripts/master/fac...
scripts/master/factory/chromium_commands.py:105: 'config.config')
On 2013/12/14 00:21:40, Nico wrote:
> Do you intend to have several configs in the future? Why doesn't
test_install.py
> just pick up the config from config/config.config relative to itself?

I'm looking into resurrecting these tests and moving them from the fyi waterfall
to the main waterfall. Came across your comment. Being able to use different
configs is useful during development, but I can see why it would be useful to
have the runner look in config/config.config by default.  I'll send you a patch
in a bit.