Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 23583032: Add onanimationXXX attributes on HTML elements. (Closed)

Created:
7 years, 3 months ago by darktears
Modified:
7 years, 3 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, adamk+blink_chromium.org, darktears, Steve Block, dino_apple.com, do-not-use, Eric Willigers
Visibility:
Public.

Description

Add onanimationXXX attributes on HTML elements. Add onanimationXXX attributes on HTML elements to match the prefixed attributes onwebkitanimationXXX. As it uses the same plumbing as a regular event listeners, it behaves the same which means that if onanimationXXX only is defined then only the code attached to this attribute will be called, if only onwebkitanimationXXX is defined then only the code attached to this attribute will be called and finally if both attributes are defined then only the code attached to the unprefixed attribute will be called. BUG=234611 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -59 lines) Patch
A + LayoutTests/animations/animation-events-prefixed-03.html View 2 chunks +11 lines, -16 lines 0 comments Download
A LayoutTests/animations/animation-events-prefixed-03-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/animations/animation-events-unprefixed-02.html View 2 chunks +11 lines, -16 lines 0 comments Download
A + LayoutTests/animations/animation-events-unprefixed-02-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/animations/animation-events-unprefixed-03.html View 2 chunks +13 lines, -24 lines 0 comments Download
A + LayoutTests/animations/animation-events-unprefixed-03-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/page/DOMWindow.h View 3 chunks +4 lines, -1 line 0 comments Download
M Source/core/page/Window.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darktears
7 years, 3 months ago (2013-09-02 19:10:38 UTC) #1
dstockwell
lgtm
7 years, 3 months ago (2013-09-03 09:34:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/23583032/1
7 years, 3 months ago (2013-09-03 11:15:51 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 11:20:47 UTC) #4
Message was sent while issue was closed.
Change committed as 157121

Powered by Google App Engine
This is Rietveld 408576698