Source/core/css/CSSParser-in.cpp - Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSParser-in.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSParser-in.cpp

diff --git a/Source/core/css/CSSParser-in.cpp b/Source/core/css/CSSParser-in.cpp

index 8907000f6087060f6bb068e600e091bfa4c0c538..0519dafc376627deb809570086689d1e226438be 100644

--- a/Source/core/css/CSSParser-in.cpp

+++ b/Source/core/css/CSSParser-in.cpp

@@ -6127,10 +6127,10 @@ bool CSSParser::fastParseColor(RGBA32& rgb, const StringType& name, bool strict)

return true;

// Try named colors.

- StyleColor color;

- color.setNamedColor(name);

- if (color.isValid()) {

- rgb = color.rgb();

+ Color tc;

+ tc.setNamedColor(name);

+ if (tc.isValid()) {

+ rgb = tc.rgb();

return true;

}

return false;