Source/core/css/resolver/MatchedPropertiesCache.cpp - Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/Source/core/css/resolver/MatchedPropertiesCache.cpp b/Source/core/css/resolver/MatchedPropertiesCache.cpp

index b3a41cf0130a0668e51970c7987d7ede00bc161b..17367953be4ece858b9713d5d91e0b28fd5c860b 100644

--- a/Source/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/Source/core/css/resolver/MatchedPropertiesCache.cpp

@@ -146,6 +146,8 @@ bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty

return false;

if (style->writingMode() != RenderStyle::initialWritingMode())

return false;

+ if (style->hasCurrentColor())

+ return false;

// The cache assumes static knowledge about which properties are inherited.

if (parentStyle->hasExplicitlyInheritedProperties())

return false;