Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: Source/core/rendering/RenderTreeAsText.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 ts << " " << quoteAndEscapeNonPrintables(toRenderFileUploadControl(& o)->fileTextValue()); 254 ts << " " << quoteAndEscapeNonPrintables(toRenderFileUploadControl(& o)->fileTextValue());
255 255
256 if (o.parent()) { 256 if (o.parent()) {
257 Color color = o.resolveColor(CSSPropertyColor); 257 Color color = o.resolveColor(CSSPropertyColor);
258 if (o.parent()->resolveColor(CSSPropertyColor) != color) 258 if (o.parent()->resolveColor(CSSPropertyColor) != color)
259 ts << " [color=" << color.nameForRenderTreeAsText() << "]"; 259 ts << " [color=" << color.nameForRenderTreeAsText() << "]";
260 260
261 // Do not dump invalid or transparent backgrounds, since that is the default. 261 // Do not dump invalid or transparent backgrounds, since that is the default.
262 Color backgroundColor = o.resolveColor(CSSPropertyBackgroundColor); 262 Color backgroundColor = o.resolveColor(CSSPropertyBackgroundColor);
263 if (o.parent()->resolveColor(CSSPropertyBackgroundColor) != backgrou ndColor 263 if (o.parent()->resolveColor(CSSPropertyBackgroundColor) != backgrou ndColor
264 && backgroundColor.rgb()) 264 && backgroundColor.isValid() && backgroundColor.rgb())
265 ts << " [bgcolor=" << backgroundColor.nameForRenderTreeAsText() << "]"; 265 ts << " [bgcolor=" << backgroundColor.nameForRenderTreeAsText() << "]";
266 266
267 Color textFillColor = o.resolveColor(CSSPropertyWebkitTextFillColor) ; 267 Color textFillColor = o.resolveColor(CSSPropertyWebkitTextFillColor) ;
268 if (o.parent()->resolveColor(CSSPropertyWebkitTextFillColor) != text FillColor 268 if (o.parent()->resolveColor(CSSPropertyWebkitTextFillColor) != text FillColor
269 && textFillColor != color && textFillColor.rgb()) 269 && textFillColor.isValid() && textFillColor != color && textFill Color.rgb())
270 ts << " [textFillColor=" << textFillColor.nameForRenderTreeAsTex t() << "]"; 270 ts << " [textFillColor=" << textFillColor.nameForRenderTreeAsTex t() << "]";
271 271
272 Color textStrokeColor = o.resolveColor(CSSPropertyWebkitTextStrokeCo lor); 272 Color textStrokeColor = o.resolveColor(CSSPropertyWebkitTextStrokeCo lor);
273 if (o.parent()->resolveColor(CSSPropertyWebkitTextStrokeColor) != te xtStrokeColor 273 if (o.parent()->resolveColor(CSSPropertyWebkitTextStrokeColor) != te xtStrokeColor
274 && textStrokeColor != color && textStrokeColor.rgb()) 274 && textStrokeColor.isValid() && textStrokeColor != color && text StrokeColor.rgb())
275 ts << " [textStrokeColor=" << textStrokeColor.nameForRenderTreeA sText() << "]"; 275 ts << " [textStrokeColor=" << textStrokeColor.nameForRenderTreeA sText() << "]";
276 276
277 if (o.parent()->style()->textStrokeWidth() != o.style()->textStrokeW idth() && o.style()->textStrokeWidth() > 0) 277 if (o.parent()->style()->textStrokeWidth() != o.style()->textStrokeW idth() && o.style()->textStrokeWidth() > 0)
278 ts << " [textStrokeWidth=" << o.style()->textStrokeWidth() << "] "; 278 ts << " [textStrokeWidth=" << o.style()->textStrokeWidth() << "] ";
279 } 279 }
280 280
281 if (!o.isBoxModelObject()) 281 if (!o.isBoxModelObject())
282 return; 282 return;
283 283
284 const RenderBoxModelObject& box = *toRenderBoxModelObject(&o); 284 const RenderBoxModelObject& box = *toRenderBoxModelObject(&o);
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 element->document().updateLayout(); 849 element->document().updateLayout();
850 850
851 RenderObject* renderer = element->renderer(); 851 RenderObject* renderer = element->renderer();
852 if (!renderer || !renderer->isListItem()) 852 if (!renderer || !renderer->isListItem())
853 return String(); 853 return String();
854 854
855 return toRenderListItem(renderer)->markerText(); 855 return toRenderListItem(renderer)->markerText();
856 } 856 }
857 857
858 } // namespace WebCore 858 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698