Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 23576012: Added .scss transform (Closed)

Created:
7 years, 3 months ago by terry
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added .scss transform Initial CSS transform BUG=

Patch Set 1 #

Patch Set 2 : split out deploy.dart #

Patch Set 3 : cleanup #

Patch Set 4 : cleanup #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -270 lines) Patch
M pkg/csslib/lib/parser.dart View 2 chunks +3 lines, -1 line 1 comment Download
A pkg/csslib/lib/transform.dart View 1 2 1 chunk +65 lines, -0 lines 1 comment Download
M pkg/csslib/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/csslib/test/compiler_test.dart View 3 chunks +29 lines, -203 lines 0 comments Download
M pkg/csslib/test/run_all.dart View 3 chunks +18 lines, -7 lines 0 comments Download
A + pkg/csslib/test/transform/common.dart View 0 chunks +-1 lines, --1 lines 2 comments Download
A pkg/csslib/test/transform/simple_test.dart View 1 2 1 chunk +192 lines, -0 lines 0 comments Download
A pkg/polymer/bin/deploy.dart View 1 1 chunk +56 lines, -0 lines 0 comments Download
M pkg/polymer/lib/deploy.dart View 1 8 chunks +8 lines, -60 lines 1 comment Download
M pkg/polymer/lib/src/transform.dart View 1 2 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
terry
Added .scss transform and test for transforms.
7 years, 3 months ago (2013-09-06 18:05:46 UTC) #1
Siggi Cherem (dart-lang)
magical =) Thanks Terry, the new transformer code looks good. My main comment below is ...
7 years, 3 months ago (2013-09-08 20:31:33 UTC) #2
Jennifer Messerly
6 years, 6 months ago (2014-06-06 17:31:08 UTC) #3
is this still needed?

Powered by Google App Engine
This is Rietveld 408576698