Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23567043: Promise init callback takes resolve and reject functions (Closed)

Created:
7 years, 3 months ago by yusukesuzuki
Modified:
7 years, 3 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Promise init callback takes resolve and reject functions The old DOM Promise spec is removed and the consensus[1] is updated. PromiseResolver is removed and instead 2 functions are given to the Promise init callback. [1]: https://github.com/domenic/promises-unwrapping Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=911213 WebKit: https://bugs.webkit.org/show_bug.cgi?id=120954 BUG=293904 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158073

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -633 lines) Patch
D LayoutTests/fast/js/Promise-already-fulfilled.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/js/Promise-already-fulfilled-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/fast/js/Promise-already-rejected.html View 1 chunk +4 lines, -5 lines 0 comments Download
M LayoutTests/fast/js/Promise-already-resolved.html View 1 chunk +6 lines, -7 lines 0 comments Download
M LayoutTests/fast/js/Promise-catch.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/js/Promise-chain.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/Promise-exception.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/js/Promise-fulfill.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/fast/js/Promise-fulfill-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/js/Promise-fulfill-in-workers.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/js/Promise-fulfill-in-workers-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/js/Promise-init.html View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/fast/js/Promise-init-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/Promise-init-in-workers-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/Promise-reject.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/Promise-resolve.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/Promise-resolve-chain.html View 2 chunks +14 lines, -14 lines 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-state.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-state-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-state-in-workers.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-state-in-workers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/Promise-resolve-with-then-exception.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/Promise-resolve-with-then-fulfill.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/Promise-resolve-with-then-reject.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/Promise-simple.html View 2 chunks +4 lines, -4 lines 0 comments Download
D LayoutTests/fast/js/Promise-simple-fulfill.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/js/Promise-simple-fulfill-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/js/Promise-simple-fulfill-inside-callback.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/js/Promise-simple-fulfill-inside-callback-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
A + LayoutTests/fast/js/Promise-simple-resolve.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/js/Promise-simple-resolve-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/fast/js/Promise-static-any.html View 1 chunk +37 lines, -38 lines 0 comments Download
M LayoutTests/fast/js/Promise-static-every.html View 1 chunk +42 lines, -43 lines 0 comments Download
M LayoutTests/fast/js/Promise-static-resolve.html View 2 chunks +3 lines, -3 lines 0 comments Download
LayoutTests/fast/js/Promise-static-some.html View 1 chunk +41 lines, -42 lines 0 comments Download
M LayoutTests/fast/js/Promise-then.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/js/Promise-then-without-callbacks.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/resources/Promise-catch-in-workers.js View 2 chunks +4 lines, -4 lines 0 comments Download
D LayoutTests/fast/js/resources/Promise-fulfill-in-workers.js View 1 chunk +0 lines, -32 lines 0 comments Download
M LayoutTests/fast/js/resources/Promise-init-in-workers.js View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/fast/js/resources/Promise-reject-in-workers.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/resources/Promise-resolve-in-workers.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/js/resources/Promise-resolve-state-in-workers.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/resources/Promise-simple-in-workers.js View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/js/resources/Promise-then-in-workers.js View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/js/resources/Promise-then-without-callbacks-in-workers.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 5 chunks +51 lines, -3 lines 0 comments Download
D Source/bindings/v8/custom/V8PromiseResolverCustom.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Promise.idl View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/dom/PromiseResolver.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/dom/PromiseResolver.idl View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yusukesuzuki
7 years, 3 months ago (2013-09-18 07:24:10 UTC) #1
yhirano
https://codereview.chromium.org/23567043/diff/1/LayoutTests/fast/js/Promise-static-some.html File LayoutTests/fast/js/Promise-static-some.html (right): https://codereview.chromium.org/23567043/diff/1/LayoutTests/fast/js/Promise-static-some.html#newcode14 LayoutTests/fast/js/Promise-static-some.html:14: Can you explain why you changed the test code? ...
7 years, 3 months ago (2013-09-18 12:52:38 UTC) #2
yusukesuzuki
https://chromiumcodereview.appspot.com/23567043/diff/1/LayoutTests/fast/js/Promise-static-some.html File LayoutTests/fast/js/Promise-static-some.html (right): https://chromiumcodereview.appspot.com/23567043/diff/1/LayoutTests/fast/js/Promise-static-some.html#newcode14 LayoutTests/fast/js/Promise-static-some.html:14: On 2013/09/18 12:52:39, yhirano wrote: > Can you explain ...
7 years, 3 months ago (2013-09-18 14:48:24 UTC) #3
yhirano
lgtm
7 years, 3 months ago (2013-09-19 04:04:53 UTC) #4
abarth-chromium
LGTM
7 years, 3 months ago (2013-09-19 18:21:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/23567043/10001
7 years, 3 months ago (2013-09-19 22:12:20 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 02:19:44 UTC) #7
Message was sent while issue was closed. 
Change committed as 158073

Powered by Google App Engine
This is Rietveld 408576698