[Activity log] Generalize the whitelist for keeping arguments

[Activity log] Generalize the whitelist for keeping arguments

Previously, we kept all arguments for only a selected set of API calls,
but preserved arguments for all DOM actions that were logged.  Change
the logic so that the whitelist can cover actions of all types, and make
the default to strip arguments for all types unless in the whitelist.

BUG=253368
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222010

[mvrable, 2013-09-06 20:34:56]

This is a change to switch to a whitelist when preserving argument lists for all
action types.

Right now this means we're dropping most details of DOM logging.  If you know of
specific calls that we want to keep more details for, I can add those here or
those can be added in a later CL.

--Michael Vrable

[felt, 2013-09-06 20:43:00]

lgtm. I don't have specific api calls off the top of my head but I'd be up for
sitting down with you & whoever else is interested next week and working up a
list. maybe monday afternoon? we might even be able to snag Nav or Eric to help
out while they're in town.

[commit-bot: I haz the power, 2013-09-06 20:44:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvrable@chromium.org/23567022/2001

[commit-bot: I haz the power, 2013-09-06 23:40:12]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-09 04:39:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvrable@chromium.org/23567022/27001

[commit-bot: I haz the power, 2013-09-09 04:39:27]

Failed to apply patch for
chrome/browser/extensions/activity_log/counting_policy_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/extensions/activity_log/counting_policy_unittest.cc
  Hunk #1 FAILED at 207.
  Hunk #2 succeeded at 201 (offset -18 lines).
  Hunk #3 succeeded at 235 with fuzz 1 (offset -18 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/activity_log/counting_policy_unittest.cc.rej

Patch:       chrome/browser/extensions/activity_log/counting_policy_unittest.cc
Index: chrome/browser/extensions/activity_log/counting_policy_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
index
053c780b1c0f104f381580f9ea81f8e1f935ab28..adfe512a208095cf6b2792fb4c0bef11cf487281
100644
--- a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
+++ b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
@@ -207,7 +207,7 @@ class CountingPolicyTest : public testing::Test {
       scoped_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(3, static_cast<int>(actions->size()));
     CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "http://www.google.com/", "", "", 1);
+                "", "http://www.google.com/", "", "", 1);
     CheckAction(*actions->at(1), "punky", Action::ACTION_API_CALL,
                 "extension.sendMessage", "[\"not\",\"stripped\"]", "", "", "",
                 1);
@@ -219,7 +219,7 @@ class CountingPolicyTest : public testing::Test {
       scoped_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
     CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "http://www.google.com/", "", "", 1);
+                "", "http://www.google.com/", "", "", 1);
     CheckAction(*actions->at(1), "punky", Action::ACTION_API_CALL, "brewster",
                 "", "", "", "", 1);
   }
@@ -253,25 +253,25 @@ class CountingPolicyTest : public testing::Test {
   static void AllURLsRemoved(scoped_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
     CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "", "", "", 1);
+                "", "", "", "", 1);
     CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "", "", "", 1);
+                "", "", "", "", 1);
   }
 
   static void SomeURLsRemoved(scoped_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(5, static_cast<int>(actions->size()));
     CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "http://www.google.com/", "Google",
+                "", "http://www.google.com/", "Google",
                 "http://www.args-url.com/", 1);
     CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "http://www.google.com/", "Google", "", 1);
+                "", "http://www.google.com/", "Google", "", 1);
     CheckAction(*actions->at(2), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "", "", "", 1);
+                "", "", "", "", 1);
     CheckAction(*actions->at(3), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "", "", "http://www.google.com/", 1);
+                "", "", "", "http://www.google.com/", 1);
     CheckAction(*actions->at(4), "punky", Action::ACTION_DOM_ACCESS, "lets",
-                "[\"vamoose\"]", "", "", "", 1);
+                "", "", "", "", 1);
   }
 
   static void CheckAction(const Action& action,

[commit-bot: I haz the power, 2013-09-09 04:50:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvrable@chromium.org/23567022/39001

[commit-bot: I haz the power, 2013-09-09 12:18:46]

Change committed as 222010