Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy.cc

Issue 23567022: [Activity log] Generalize the whitelist for keeping arguments (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy.cc
diff --git a/chrome/browser/extensions/activity_log/counting_policy.cc b/chrome/browser/extensions/activity_log/counting_policy.cc
index 3c5b737532b05742f7daac77df45c64977bfe696..3d55a1e808f72aae51a1356ae814bf557c2381be 100644
--- a/chrome/browser/extensions/activity_log/counting_policy.cc
+++ b/chrome/browser/extensions/activity_log/counting_policy.cc
@@ -46,6 +46,8 @@ using content::BrowserThread;
namespace {
+using extensions::Action;
+
// Delay between cleaning passes (to delete old action records) through the
// database.
const int kCleaningDelayInHours = 12;
@@ -56,8 +58,19 @@ const int kCleaningDelayInHours = 12;
//
// TODO(mvrable): The contents of this whitelist should be reviewed and
// expanded as needed.
-const char* kAlwaysLog[] = {"extension.connect", "extension.sendMessage",
- "tabs.executeScript", "tabs.insertCSS"};
+struct ApiList {
+ Action::ActionType type;
+ const char* name;
+};
+
+const ApiList kAlwaysLog[] = {
+ {Action::ACTION_API_CALL, "extension.connect"},
+ {Action::ACTION_API_CALL, "extension.sendMessage"},
+ {Action::ACTION_API_CALL, "tabs.executeScript"},
+ {Action::ACTION_API_CALL, "tabs.insertCSS"},
+ {Action::ACTION_CONTENT_SCRIPT, ""},
+ {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open"},
+};
// Columns in the main database table. See the file-level comment for a
// discussion of how data is stored and the meanings of the _x columns.
@@ -138,7 +151,8 @@ CountingPolicy::CountingPolicy(Profile* profile)
url_table_("url_ids"),
retention_time_(base::TimeDelta::FromHours(60)) {
for (size_t i = 0; i < arraysize(kAlwaysLog); i++) {
- api_arg_whitelist_.insert(kAlwaysLog[i]);
+ api_arg_whitelist_.insert(
+ std::make_pair(kAlwaysLog[i].type, kAlwaysLog[i].name));
}
}

Powered by Google App Engine
This is Rietveld 408576698