Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Issue 23562002: Will now force the volume of all input devices in the WebRTC audio test. (Closed)

Created:
7 years, 3 months ago by phoglund_chromium
Modified:
7 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Will now force the volume of all input devices in the WebRTC audio test. The WebRTC audio quality test has been relying on a particular configuration for the input device name, but it has turned out to be painful to maintain. Specifically, it used to require that the default input source was named "render.monitor" to figure out which device to force the volume to 100% on, but now it will just force the volume on all input devices it can find on the system. The volume is forced to 100% since PESQ will be confused if the recording is too low in volume (or even refuse to run if the recording is done at 0% volume, which obviously will make for a bad comparison). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221251

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixed win compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 2 4 chunks +27 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
phoglund_chromium
7 years, 3 months ago (2013-08-27 09:32:56 UTC) #1
phoglund_chromium
ping
7 years, 3 months ago (2013-08-30 09:48:41 UTC) #2
no longer working on chromium
On 2013/08/30 09:48:41, phoglund wrote: > ping lgtm
7 years, 3 months ago (2013-08-30 11:53:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/23562002/6001
7 years, 3 months ago (2013-09-04 16:35:49 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on chromium_presubmit HTTP Error 400: Bad Request
7 years, 3 months ago (2013-09-04 16:36:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/23562002/23001
7 years, 3 months ago (2013-09-04 16:42:55 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 20:21:55 UTC) #7
Message was sent while issue was closed.
Change committed as 221251

Powered by Google App Engine
This is Rietveld 408576698