Will now force the volume of all input devices in the WebRTC audio test.

chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ctime>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
@@ skipping 54 matching lines @@
 // This test will only work on machines that have been configured to record
 // their own input.
 //
 // On Linux:
 // 1. # sudo apt-get install pavucontrol
 // 2. For the user who will run the test: # pavucontrol
 // 3. In a separate terminal, # arecord dummy
 // 4. In pavucontrol, go to the recording tab.
 // 5. For the ALSA plug-in [aplay]: ALSA Capture from, change from <x> to
 //    <Monitor of x>, where x is whatever your primary sound device is called.
-//    This test expects the device id to be render.monitor - if it's something
-//    else, the microphone level will not get forced to 100% appropriately.
-//    See ForceMicrophoneVolumeTo100% for more details. You can list the
-//    available monitor devices on your system by running the command
-//    pacmd list-sources | grep name | grep monitor.
 // 6. Try launching chrome as the target user on the target machine, try
 //    playing, say, a YouTube video, and record with # arecord -f dat tmp.dat.
 //    Verify the recording with aplay (should have recorded what you played
 //    from chrome).
 //
+// Note: the volume for ALL your input devices will be forced to 100% by
+//       running this test on Linux.
+//
 // On Windows 7:
 // 1. Control panel > Sound > Manage audio devices.
 // 2. In the recording tab, right-click in an empty space in the pane with the
 //    devices. Tick 'show disabled devices'.
 // 3. You should see a 'stero mix' device - this is what your speakers output.
 //    Right click > Properties.
 // 4. In the Listen tab for the mix device, check the 'listen to this device'
 //    checkbox. Ensure the mix device is the default recording device.
 // 5. Launch chrome and try playing a video with sound. You should see
 //    in the volume meter for the mix device. Configure the mix device to have
@@ skipping 164 matching lines @@
   // Joins the recording program. Returns true on success.
   bool WaitForRecordingToEnd() {
     int exit_code = -1;
     base::WaitForExitCode(recording_application_, &exit_code);
     return exit_code == 0;
   }
  private:
   base::ProcessHandle recording_application_;
 };
 
-void ForceMicrophoneVolumeTo100Percent() {
+bool ForceMicrophoneVolumeTo100Percent() {
 #if defined(OS_WIN)
   CommandLine command_line(GetTestDataDir().Append(kToolsPath).Append(
       FILE_PATH_LITERAL("force_mic_volume_max.exe")));
-#else
-  const std::string kRecordingDeviceId = "render.monitor";
-  const std::string kHundredPercentVolume = "65536";
-
-  CommandLine command_line(base::FilePath(FILE_PATH_LITERAL("pacmd")));
-  command_line.AppendArg("set-source-volume");
-  command_line.AppendArg(kRecordingDeviceId);
-  command_line.AppendArg(kHundredPercentVolume);
-#endif
-
   LOG(INFO) << "Running " << command_line.GetCommandLineString();
   std::string result;
   if (!base::GetAppOutput(command_line, &result)) {
-    // It's hard to figure out for instance the default PA recording device name
-    // for different systems, so just warn here. Users will most often have a
-    // reasonable mic level on their systems.
-    LOG(WARNING) << "Failed to set mic volume to 100% on your system. " <<
-        "The test may fail or have results distorted; please ensure that " <<
-        "your mic level is 100% manually.";
+    LOG(ERROR) << "Failed to set source volume: output was " << result;
+    return false;
   }
+#else
+  // Just force the volume of, say the first 5 devices. A machine will rarely
+  // have more input sources than that. This is way easier than finding the
+  // input device we happen to be using.
+  for (int device_index = 0; device_index < 5; ++device_index) {
+    std::string result;
+    const std::string kHundredPercentVolume = "65536";
+    CommandLine command_line(base::FilePath(FILE_PATH_LITERAL("pacmd")));
+    command_line.AppendArg("set-source-volume");
+    command_line.AppendArg(base::StringPrintf("%d", device_index));
+    command_line.AppendArg(kHundredPercentVolume);
+    LOG(INFO) << "Running " << command_line.GetCommandLineString();
+    if (!base::GetAppOutput(command_line, &result)) {
+      LOG(ERROR) << "Failed to set source volume: output was " << result;
+      return false;
+    }
+  }
+#endif
+  return true;
 }
 
 // Removes silence from beginning and end of the |input_audio_file| and writes
 // the result to the |output_audio_file|. Returns true on success.
 bool RemoveSilence(const base::FilePath& input_file,
                    const base::FilePath& output_file) {
   // SOX documentation for silence command: http://sox.sourceforge.net/sox.html
   // To remove the silence from both beginning and end of the audio file, we
   // call sox silence command twice: once on normal file and again on its
   // reverse, then we reverse the final output.
@@ skipping 104 matching lines @@
 #define MAYBE_MANUAL_TestAudioQuality MANUAL_TestAudioQuality
 #else
 #define MAYBE_MANUAL_TestAudioQuality DISABLED_MANUAL_TestAudioQuality
 #endif
 
 IN_PROC_BROWSER_TEST_F(WebrtcAudioQualityBrowserTest,
                        MAYBE_MANUAL_TestAudioQuality) {
 #if defined(OS_WIN)
   if (base::win::GetVersion() < base::win::VERSION_VISTA) {
     // It would take work to implement this on XP; not prioritized right now.
-    LOG(INFO) << "This test is not implemented for Windows XP.";
+    LOG(ERROR) << "This test is not implemented for Windows XP.";
     return;
   }
 #endif
   ASSERT_TRUE(HasAllRequiredResources());
   // TODO(phoglund): make this use embedded_test_server when that test server
   // can handle files > ~400Kb.
   ASSERT_TRUE(test_server()->Start());
   ASSERT_TRUE(peerconnection_server_.Start());
 
-  ForceMicrophoneVolumeTo100Percent();
+  ASSERT_TRUE(ForceMicrophoneVolumeTo100Percent());
 
   ui_test_utils::NavigateToURL(
       browser(), test_server()->GetURL(kMainWebrtcTestHtmlPage));
   content::WebContents* left_tab =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   chrome::AddBlankTabAt(browser(), -1, true);
   content::WebContents* right_tab =
       browser()->tab_strip_model()->GetActiveWebContents();
   ui_test_utils::NavigateToURL(
@@ skipping 51 matching lines @@
                       &raw_mos, &mos_lqo));
 
   perf_test::PrintResult("audio_pesq", "", "raw_mos", raw_mos, "score", true);
   perf_test::PrintResult("audio_pesq", "", "mos_lqo", mos_lqo, "score", true);
 
   EXPECT_TRUE(base::DeleteFile(recording, false));
   EXPECT_TRUE(base::DeleteFile(trimmed_recording, false));
 
   ASSERT_TRUE(peerconnection_server_.Stop());
 }