Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5599)

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.h

Issue 23557004: Save password bubble pops up automatically (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor change Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/content_setting_image_view.h
diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.h b/chrome/browser/ui/views/location_bar/content_setting_image_view.h
index 350b3fd760db1df2fb503a94d2f543e31432a9d9..85e5d8da33634ff6d9ea7b4fa1fcf2c374ebbd94 100644
--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.h
+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.h
@@ -41,8 +41,12 @@ class ContentSettingImageView : public ui::AnimationDelegate,
SkColor parent_background_color);
virtual ~ContentSettingImageView();
- // Update the decoration from the shown WebContents.
- void Update(content::WebContents* web_contents);
+ // Updates the decoration from the shown WebContents.
+ void UpdatePreLayout(content::WebContents* web_contents);
+
+ // Performs any updates which depend on the image having already been laid out
+ // by the owning LocationBarView.
+ void UpdatePostLayout(content::WebContents* web_contents);
private:
// Number of milliseconds spent animating open; also the time spent animating
@@ -82,6 +86,7 @@ class ContentSettingImageView : public ui::AnimationDelegate,
int GetTotalSpacingWhileAnimating() const;
void OnClick();
+ void CreateBubble(content::WebContents* web_contents);
LocationBarView* parent_; // Weak, owns us.
scoped_ptr<ContentSettingImageModel> content_setting_image_model_;

Powered by Google App Engine
This is Rietveld 408576698