Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7121)

Unified Diff: chrome/browser/ui/content_settings/content_setting_image_model.cc

Issue 23557004: Save password bubble pops up automatically (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor change Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_image_model.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_image_model.cc b/chrome/browser/ui/content_settings/content_setting_image_model.cc
index 764e1c91ee54caacb969d8722fec852a1f8bee24..3b4ecb8034f1a827b8ef6ba3ba8d8a65da73fd74 100644
--- a/chrome/browser/ui/content_settings/content_setting_image_model.cc
+++ b/chrome/browser/ui/content_settings/content_setting_image_model.cc
@@ -64,6 +64,7 @@ class ContentSettingSavePasswordImageModel : public ContentSettingImageModel {
ContentSettingSavePasswordImageModel();
virtual void UpdateFromWebContents(WebContents* web_contents) OVERRIDE;
+ virtual bool ShouldShowBubbleOnBlockage() OVERRIDE;
};
namespace {
@@ -233,6 +234,10 @@ void ContentSettingSavePasswordImageModel::UpdateFromWebContents(
}
}
+bool ContentSettingSavePasswordImageModel::ShouldShowBubbleOnBlockage() {
+ return true;
+}
+
ContentSettingMediaImageModel::ContentSettingMediaImageModel(
ContentSettingsType type)
: ContentSettingImageModel(type) {
@@ -377,6 +382,10 @@ ContentSettingImageModel::ContentSettingImageModel(
explanatory_string_id_(0) {
}
+bool ContentSettingImageModel::ShouldShowBubbleOnBlockage() {
+ return false;
+}
+
// static
ContentSettingImageModel*
ContentSettingImageModel::CreateContentSettingImageModel(

Powered by Google App Engine
This is Rietveld 408576698