Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: chrome/browser/google_apis/drive_api_requests.h

Issue 23549003: Refactor GetChangelistRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/drive/drive_api_service.cc ('k') | chrome/browser/google_apis/drive_api_requests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_apis/drive_api_requests.h
diff --git a/chrome/browser/google_apis/drive_api_requests.h b/chrome/browser/google_apis/drive_api_requests.h
index 62fb26e91c487dd0679fdd7da54e5aa47831b2ed..2d7b5f489fe27aa7e27145f1ead6cf1b660f911b 100644
--- a/chrome/browser/google_apis/drive_api_requests.h
+++ b/chrome/browser/google_apis/drive_api_requests.h
@@ -14,6 +14,7 @@
namespace google_apis {
+class ChangeList;
class FileResource;
class FileList;
@@ -28,39 +29,10 @@ typedef base::Callback<void(GDataErrorCode error,
typedef base::Callback<void(GDataErrorCode error,
scoped_ptr<FileList> entry)> FileListCallback;
-//============================ GetChangelistRequest ==========================
-
-// This class performs the request for fetching changelist.
-// The result may contain only first part of the result. The remaining result
-// should be able to be fetched by ContinueGetFileListRequest defined below.
-class GetChangelistRequest : public GetDataRequest {
- public:
- // |include_deleted| specifies if the response should contain the changes
- // for deleted entries or not.
- // |start_changestamp| specifies the starting point of change list or 0 if
- // all changes are necessary.
- // |max_results| specifies the max of the number of files resource in the
- // response.
- GetChangelistRequest(RequestSender* sender,
- const DriveApiUrlGenerator& url_generator,
- bool include_deleted,
- int64 start_changestamp,
- int max_results,
- const GetDataCallback& callback);
- virtual ~GetChangelistRequest();
-
- protected:
- // Overridden from GetDataRequest.
- virtual GURL GetURL() const OVERRIDE;
-
- private:
- const DriveApiUrlGenerator url_generator_;
- const bool include_deleted_;
- const int64 start_changestamp_;
- const int max_results_;
-
- DISALLOW_COPY_AND_ASSIGN(GetChangelistRequest);
-};
+// Callback used for requests that the server returns ChangeList data
+// formatted into JSON value.
+typedef base::Callback<void(GDataErrorCode error,
+ scoped_ptr<ChangeList> entry)> ChangeListCallback;
namespace drive {
@@ -225,6 +197,54 @@ class AboutGetRequest : public GetDataRequest {
DISALLOW_COPY_AND_ASSIGN(AboutGetRequest);
};
+//============================ ChangesListRequest ============================
+
+// This class performs the request for fetching ChangeList.
+// The result may contain only first part of the result. The remaining result
+// should be able to be fetched by ContinueGetFileListRequest defined below.
+// or by ChangesListRequest with setting page token.
+// This request is mapped to
+// https://developers.google.com/drive/v2/reference/changes/list
+class ChangesListRequest : public GetDataRequest {
+ public:
+ ChangesListRequest(RequestSender* sender,
+ const DriveApiUrlGenerator& url_generator,
+ const ChangeListCallback& callback);
+ virtual ~ChangesListRequest();
+
+ // Optional parameter
+ bool include_deleted() const { return include_deleted_; }
+ void set_include_deleted(bool include_deleted) {
+ include_deleted_ = include_deleted;
+ }
+
+ int max_results() const { return max_results_; }
+ void set_max_results(int max_results) { max_results_ = max_results; }
+
+ const std::string& page_token() const { return page_token_; }
+ void set_page_token(const std::string& page_token) {
+ page_token_ = page_token;
+ }
+
+ int64 start_change_id() const { return start_change_id_; }
+ void set_start_change_id(int64 start_change_id) {
+ start_change_id_ = start_change_id;
+ }
+
+ protected:
+ // Overridden from GetDataRequest.
+ virtual GURL GetURL() const OVERRIDE;
+
+ private:
+ const DriveApiUrlGenerator url_generator_;
+ bool include_deleted_;
+ int max_results_;
+ std::string page_token_;
+ int64 start_change_id_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChangesListRequest);
+};
+
//============================= AppsListRequest ============================
// This class performs the request for fetching AppList.
« no previous file with comments | « chrome/browser/drive/drive_api_service.cc ('k') | chrome/browser/google_apis/drive_api_requests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698