Issue 23535002: Fixed case where _generated_background_page.html was still showing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23535002: Fixed case where _generated_background_page.html was still showing. (Closed)

Created:
7 years, 3 months ago by dvh

Modified:
7 years, 3 months ago

Reviewers:
xiyuan, asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixed case where _generated_background_page.html was still showing. Make sure to compute generated_background_page value in all cases. BUG=276519 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220486

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -16 lines)			Patch
M	chrome/browser/extensions/api/developer_private/developer_private_api.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/developer_private/developer_private_api.cc	View	5 chunks	+23 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	5 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dvh

xiyuan@ for chrome/browser/ui/webui/extensions/* asargent@ for chrome/browser/extensions/api/developer_private/* PTAL. Thanks!

7 years, 3 months ago (2013-08-27 04:57:37 UTC) #1

dvh

On 2013/08/27 04:57:37, dvh wrote: > xiyuan@ for chrome/browser/ui/webui/extensions/* > asargent@ for chrome/browser/extensions/api/developer_private/* > > ...

7 years, 3 months ago (2013-08-28 23:10:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dvh@chromium.org/23535002/1

7 years, 3 months ago (2013-08-29 22:13:18 UTC) #5

Message was sent while issue was closed.

Change committed as 220486

Expand Messages | Collapse Messages