Fixed case where _generated_background_page.html was still showing.

chrome/browser/extensions/api/developer_private/developer_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include "apps/app_load_service.h"
 #include "apps/app_restore_service.h"
 #include "apps/saved_files_service.h"
 #include "apps/shell_window.h"
@@ skipping 325 matching lines @@
   info->may_disable = system->management_policy()->
       UserMayModifySettings(&item, NULL);
   info->is_app = item.is_app();
   info->views = GetInspectablePagesForExtension(&item, item_is_enabled);
 
   return info.Pass();
 }
 
 void DeveloperPrivateGetItemsInfoFunction::
     GetInspectablePagesForExtensionProcess(
+        const Extension* extension,
         const std::set<content::RenderViewHost*>& views,
         ItemInspectViewList* result) {
+  bool has_generated_background_page =
+      BackgroundInfo::HasGeneratedBackgroundPage(extension);
   for (std::set<content::RenderViewHost*>::const_iterator iter = views.begin();
        iter != views.end(); ++iter) {
     content::RenderViewHost* host = *iter;
     content::WebContents* web_contents =
         content::WebContents::FromRenderViewHost(host);
     ViewType host_type = GetViewType(web_contents);
     if (VIEW_TYPE_EXTENSION_POPUP == host_type ||
         VIEW_TYPE_EXTENSION_DIALOG == host_type)
       continue;
 
     content::RenderProcessHost* process = host->GetProcess();
-    result->push_back(
-        constructInspectView(web_contents->GetURL(),
-                             process->GetID(),
-                             host->GetRoutingID(),
-                             process->GetBrowserContext()->IsOffTheRecord(),
-                             false));
+    bool is_background_page =
+        (web_contents->GetURL() == BackgroundInfo::GetBackgroundURL(extension));
+    result->push_back(constructInspectView(
+        web_contents->GetURL(),
+        process->GetID(),
+        host->GetRoutingID(),
+        process->GetBrowserContext()->IsOffTheRecord(),
+        is_background_page && has_generated_background_page));
   }
 }
 
 void DeveloperPrivateGetItemsInfoFunction::
     GetShellWindowPagesForExtensionProfile(
         const Extension* extension,
         ItemInspectViewList* result) {
   ShellWindowRegistry* registry = ShellWindowRegistry::Get(profile());
   if (!registry) return;
 
   const ShellWindowRegistry::ShellWindowList windows =
       registry->GetShellWindowsForApp(extension->id());
 
+  bool has_generated_background_page =
+      BackgroundInfo::HasGeneratedBackgroundPage(extension);
   for (ShellWindowRegistry::const_iterator it = windows.begin();
        it != windows.end(); ++it) {
     content::WebContents* web_contents = (*it)->web_contents();
     RenderViewHost* host = web_contents->GetRenderViewHost();
     content::RenderProcessHost* process = host->GetProcess();
-    result->push_back(
-        constructInspectView(web_contents->GetURL(),
-                             process->GetID(),
-                             host->GetRoutingID(),
-                             process->GetBrowserContext()->IsOffTheRecord(),
-                             false));
+    bool is_background_page =
+        (web_contents->GetURL() == BackgroundInfo::GetBackgroundURL(extension));
+    result->push_back(constructInspectView(
+        web_contents->GetURL(),
+        process->GetID(),
+        host->GetRoutingID(),
+        process->GetBrowserContext()->IsOffTheRecord(),
+        is_background_page && has_generated_background_page));
   }
 }
 
 linked_ptr<developer::ItemInspectView> DeveloperPrivateGetItemsInfoFunction::
     constructInspectView(
         const GURL& url,
         int render_process_id,
         int render_view_id,
         bool incognito,
         bool generated_background_page) {
@@ skipping 17 matching lines @@
 ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::
     GetInspectablePagesForExtension(
         const Extension* extension,
         bool extension_is_enabled) {
 
   ItemInspectViewList result;
   // Get the extension process's active views.
   ExtensionProcessManager* process_manager =
       ExtensionSystem::Get(profile())->process_manager();
   GetInspectablePagesForExtensionProcess(
+      extension,
       process_manager->GetRenderViewHostsForExtension(extension->id()),
       &result);
 
   // Get shell window views
   GetShellWindowPagesForExtensionProfile(extension, &result);
 
   // Include a link to start the lazy background page, if applicable.
   if (BackgroundInfo::HasLazyBackgroundPage(extension) &&
       extension_is_enabled &&
       !process_manager->GetBackgroundHostForExtension(extension->id())) {
     result.push_back(constructInspectView(
         BackgroundInfo::GetBackgroundURL(extension),
         -1,
         -1,
         false,
         BackgroundInfo::HasGeneratedBackgroundPage(extension)));
   }
 
   ExtensionService* service = profile()->GetExtensionService();
   // Repeat for the incognito process, if applicable. Don't try to get
   // shell windows for incognito process.
   if (service->profile()->HasOffTheRecordProfile() &&
       IncognitoInfo::IsSplitMode(extension)) {
     process_manager = ExtensionSystem::Get(
         service->profile()->GetOffTheRecordProfile())->process_manager();
     GetInspectablePagesForExtensionProcess(
+        extension,
         process_manager->GetRenderViewHostsForExtension(extension->id()),
         &result);
 
     if (BackgroundInfo::HasLazyBackgroundPage(extension) &&
         extension_is_enabled &&
         !process_manager->GetBackgroundHostForExtension(extension->id())) {
     result.push_back(constructInspectView(
         BackgroundInfo::GetBackgroundURL(extension),
         -1,
         -1,
@@ skipping 807 matching lines @@
 
   #undef   SET_STRING
   return true;
 }
 
 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {}
 
 } // namespace api
 
 } // namespace extensions