Issue 23534023: ash: Minor cleanup, move more files from launcher to shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23534023: ash: Minor cleanup, move more files from launcher to shelf. (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
xiyuan, James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ash: Minor cleanup, move more files from launcher to shelf. Moves the ones that do not involve renaming. BUG=248353 R=jamescook@chromium.org,xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220481

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -733 lines)			Patch
M	ash/ash.gyp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/launcher/launcher_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	ash/launcher/overflow_bubble.h	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	ash/launcher/overflow_bubble.cc	View	1 chunk	+0 lines, -285 lines	0 comments	Download
D	ash/launcher/overflow_button.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	ash/launcher/overflow_button.cc	View	1 chunk	+0 lines, -178 lines	0 comments	Download
D	ash/launcher/scoped_observer_with_duplicated_sources.h	View	1 chunk	+0 lines, -70 lines	0 comments	Download
D	ash/launcher/scoped_observer_with_duplicated_sources_unittest.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
A +	ash/shelf/overflow_bubble.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/shelf/overflow_bubble.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	ash/shelf/overflow_button.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/shelf/overflow_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	ash/shelf/scoped_observer_with_duplicated_sources.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/shelf/scoped_observer_with_duplicated_sources_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/test/launcher_view_test_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/browser_status_monitor.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23534023/1

7 years, 3 months ago (2013-08-29 23:18:03 UTC) #3

Message was sent while issue was closed.

Change committed as 220481