Issue 23533007: Replace responseType mismatch handling code in XMLHttpRequest::responseJSONSource() with ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533007: Replace responseType mismatch handling code in XMLHttpRequest::responseJSONSource() with ASSERT (Closed)

Created:
7 years, 3 months ago by tyoshino (SeeGerritForStatus)

Modified:
7 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Replace responseType mismatch handling code in XMLHttpRequest::responseJSONSource() with ASSERT Like responseBlob() and responseArrayBuffer() method, this method is called from V8XMLHttpRequestCustom where it's responseType is guaranteed to be ResponseTypeJSON. So, just ASSERT it. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156909

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -7 lines)			Patch
M	Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLHttpRequest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLHttpRequest.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/23533007/1

7 years, 3 months ago (2013-08-29 04:54:56 UTC) #3

Message was sent while issue was closed.

Change committed as 156909

Expand Messages | Collapse Messages