Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp - Issue 23533007: Replace responseType mismatch handling code in XMLHttpRequest::responseJSONSource() with ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 23533007: Replace responseType mismatch handling code in XMLHttpRequest::responseJSONSource() with ASSERT (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

diff --git a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

index e5806519ba16c46da8068b527849363382aaabcb..f28fa19fe26395e21432fe1529d738d0c285f7fb 100644

--- a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

+++ b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

@@ -97,7 +97,7 @@ void V8XMLHttpRequest::responseAttributeGetterCustom(v8::Local<v8::String> name,

v8::Isolate* isolate = info.GetIsolate();

ExceptionState es(isolate);

- ScriptString jsonSource = xmlHttpRequest->responseJSONSource(es);

+ ScriptString jsonSource = xmlHttpRequest->responseJSONSource();

if (es.throwIfNeeded())

return;

« no previous file with comments | « no previous file | Source/core/xml/XMLHttpRequest.h » ('j') | no next file with comments »