Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 23532067: Pass '--verbose' and '--retries 0' flags to run_test_cases.py for ThreadSanitizer. (Closed)

Created:
7 years, 3 months ago by Alexander Potapenko
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, earthdok
Visibility:
Public.

Description

Pass '--verbose' and '--retries 0' flags to run_test_cases.py for ThreadSanitizer. This allows to report a race even in the case it's flaky. BUG=128314 R=maruel@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M scripts/slave/runtest.py View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alexander Potapenko
PTAL
7 years, 3 months ago (2013-09-13 15:09:45 UTC) #1
M-A Ruel
https://codereview.chromium.org/23532067/diff/1/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/23532067/diff/1/scripts/slave/runtest.py#newcode1238 scripts/slave/runtest.py:1238: if options.sharding_args is None: Worth using default='' at the ...
7 years, 3 months ago (2013-09-13 15:16:25 UTC) #2
M-A Ruel
I meant default=[] but Rietveld is stuck. 2013/9/13 <maruel@chromium.org> > > https://codereview.chromium.**org/23532067/diff/1/scripts/** > slave/runtest.py<https://codereview.chromium.org/23532067/diff/1/scripts/slave/runtest.py> > ...
7 years, 3 months ago (2013-09-13 15:17:45 UTC) #3
Alexander Potapenko
Done. https://codereview.chromium.org/23532067/diff/1/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/23532067/diff/1/scripts/slave/runtest.py#newcode1238 scripts/slave/runtest.py:1238: if options.sharding_args is None: On 2013/09/13 15:16:25, M-A ...
7 years, 3 months ago (2013-09-13 15:23:08 UTC) #4
M-A Ruel
https://codereview.chromium.org/23532067/diff/7001/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/23532067/diff/7001/scripts/slave/runtest.py#newcode1240 scripts/slave/runtest.py:1240: options.sharding_args += '--retries 0' ' --retries 0'
7 years, 3 months ago (2013-09-13 15:24:05 UTC) #5
Alexander Potapenko
https://codereview.chromium.org/23532067/diff/7001/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/23532067/diff/7001/scripts/slave/runtest.py#newcode1240 scripts/slave/runtest.py:1240: options.sharding_args += '--retries 0' On 2013/09/13 15:24:05, M-A Ruel ...
7 years, 3 months ago (2013-09-13 15:26:20 UTC) #6
M-A Ruel
lgtm
7 years, 3 months ago (2013-09-13 15:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/23532067/13001
7 years, 3 months ago (2013-09-13 15:31:19 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 15:32:08 UTC) #9
Message was sent while issue was closed.
Change committed as 223047

Powered by Google App Engine
This is Rietveld 408576698