Issue 23532055: XMLSerializer.serializeToString() should throw exception for invalid node value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23532055: XMLSerializer.serializeToString() should throw exception for invalid node value. (Closed)

Created:
7 years, 3 months ago by vivekg_samsung

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium, vivekg__, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

XMLSerializer.serializeToString() should throw exception for invalid node value. FF and Opera 12 (pre blink/webkit) throw exception in case the node value is invalid. Blink sends an empty string as the result of serializeToString operation with invalid node. We should match with other browsers for throwing it as an exception. R=eseidel, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157617

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -1 line)			Patch
A	LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception.html	View	1 chunk	+105 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	Source/core/xml/XMLSerializer.cpp	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

So the behavior of that test now matches FF? If so, lgtm.

7 years, 3 months ago (2013-09-11 14:40:20 UTC) #2

vivekg_samsung

On 2013/09/11 14:40:20, eseidel wrote: > So the behavior of that test now matches FF? ...

7 years, 3 months ago (2013-09-11 14:48:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23532055/1

7 years, 3 months ago (2013-09-11 16:20:44 UTC) #4

Message was sent while issue was closed.

Change committed as 157617

Expand Messages | Collapse Messages