Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: Source/core/xml/XMLSerializer.cpp

Issue 23532055: XMLSerializer.serializeToString() should throw exception for invalid node value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig (sam@webkit.org) 3 * Copyright (C) 2006 Samuel Weinig (sam@webkit.org)
4 * Copyright (C) 2013 Samsung Electronics. All rights reserved.
4 * 5 *
5 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Lesser General Public 7 * modify it under the terms of the GNU Lesser General Public
7 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
9 * 10 *
10 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Lesser General Public License for more details. 14 * Lesser General Public License for more details.
14 * 15 *
15 * You should have received a copy of the GNU Lesser General Public 16 * You should have received a copy of the GNU Lesser General Public
16 * License along with this library; if not, write to the Free Software 17 * License along with this library; if not, write to the Free Software
17 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 U SA 18 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 U SA
18 */ 19 */
19 20
20 #include "config.h" 21 #include "config.h"
21 #include "core/xml/XMLSerializer.h" 22 #include "core/xml/XMLSerializer.h"
22 23
23 #include "bindings/v8/ExceptionState.h" 24 #include "bindings/v8/ExceptionState.h"
24 #include "core/dom/Document.h" 25 #include "core/dom/Document.h"
25 #include "core/dom/ExceptionCode.h" 26 #include "core/dom/ExceptionCode.h"
26 #include "core/editing/markup.h" 27 #include "core/editing/markup.h"
27 #include "wtf/text/WTFString.h" 28 #include "wtf/text/WTFString.h"
28 29
29 namespace WebCore { 30 namespace WebCore {
30 31
31 String XMLSerializer::serializeToString(Node* node, ExceptionState& es) 32 String XMLSerializer::serializeToString(Node* node, ExceptionState& es)
32 { 33 {
33 if (!node) 34 if (!node) {
35 es.throwDOMException(TypeError, "Invalid node value.");
34 return String(); 36 return String();
37 }
35 38
36 return createMarkup(node); 39 return createMarkup(node);
37 } 40 }
38 41
39 } // namespace WebCore 42 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698