Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 23530070: backup for dynamic recent tabs submenu (Closed)

Created:
7 years, 3 months ago by kuan
Modified:
7 years, 2 months ago
Reviewers:
Visibility:
Public.

Description

backup for dynamic recent tabs submenu

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fixed bugs #

Patch Set 4 : retry #

Patch Set 5 : block dnaymic menu for mac #

Patch Set 6 : add chks for ids and indexes #

Patch Set 7 : code clnup #

Patch Set 8 : rm logging #

Patch Set 9 : re-upload #

Patch Set 10 : addr'ed all scott's comments except RecentTabsMenuModelDelegate #

Patch Set 11 : new RecentTabsMenuModelDelegate w/ new intf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+820 lines, -374 lines) Patch
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h View 1 2 3 4 5 6 7 6 chunks +48 lines, -19 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 2 3 4 5 6 7 15 chunks +252 lines, -134 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 2 3 4 5 6 7 8 9 9 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/browser/ui/views/menu_items_changed_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/recent_tabs_menu_model_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/recent_tabs_menu_model_delegate.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +128 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.h View 1 2 3 4 5 6 7 8 9 10 9 chunks +27 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 3 4 5 6 7 8 9 10 20 chunks +124 lines, -113 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 4 chunks +7 lines, -4 lines 0 comments Download
M ui/base/models/menu_model_delegate.h View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -0 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/models/simple_menu_model.cc View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -54 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.cc View 1 2 3 4 5 6 7 8 9 2 chunks +74 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698