[cleanup] Remove LauncherItemChanged() from LauncherItemController

[cleanup] Remove LauncherItemChanged() from LauncherItemController 

No one have interests LauncherItemChanged().

R=skuhne@chromium.org
BUG=NONE
TEST=Compiles

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221510

[simonhong_, 2013-09-04 02:24:44]

Dear stefan,
Please take a look.

[Mr4D (OOO till 08-26), 2013-09-04 03:47:02]

See comment.

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:998: const
ash::LauncherItem& old_item) {
You removed the LauncherItemChanged everywhere. Is this empty function still
required?

[simonhong_, 2013-09-04 04:12:03]

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:998: const
ash::LauncherItem& old_item) {
On 2013/09/04 03:47:02, Mr4D wrote:
> You removed the LauncherItemChanged everywhere. Is this empty function still
> required?

This is not needed in CLC.
But I can't remove because this is pure abstract method.

[Mr4D (OOO till 08-26), 2013-09-04 14:43:47]

Please have another look!

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:998: const
ash::LauncherItem& old_item) {
Right. But ... I was looking quickly over the 16 references to
LauncherItemChanged and I might be wrong, but it looks like that this can be
removed now altogether since this was the only recipient for these calls.

[simonhong_, 2013-09-04 16:41:23]

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:998: const
ash::LauncherItem& old_item) {
On 2013/09/04 14:43:47, Mr4D wrote:
> Right. But ... I was looking quickly over the 16 references to
> LauncherItemChanged and I might be wrong, but it looks like that this can be
> removed now altogether since this was the only recipient for these calls.

But.. LauncherItemMoved() is still needed by CLC.
Do I miss something from your comment?

[simonhong_, 2013-09-04 17:48:21]

On 2013/09/04 16:41:23, Simon YoungKi Hong wrote:
>
https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
> File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):
> 
>
https://codereview.chromium.org/23530020/diff/1/chrome/browser/ui/ash/launche...
> chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:998: const
> ash::LauncherItem& old_item) {
> On 2013/09/04 14:43:47, Mr4D wrote:
> > Right. But ... I was looking quickly over the 16 references to
> > LauncherItemChanged and I might be wrong, but it looks like that this can be
> > removed now altogether since this was the only recipient for these calls.
> 
> But.. LauncherItemMoved() is still needed by CLC.
> Do I miss something from your comment?

Do you mean removing LauncherItemChanged() from LauncherModelObserver?

[Mr4D (OOO till 08-26), 2013-09-05 03:03:45]

Yes - that is what I have meant. Since the LauncherItemChanged seems not to be
used anywhere anymore we can remove it from LauncherModelObserver.

Makes sense?

[simonhong_, 2013-09-05 03:04:53]

On 2013/09/05 03:03:45, Mr4D wrote:
> Yes - that is what I have meant. Since the LauncherItemChanged seems not to be
> used anywhere anymore we can remove it from LauncherModelObserver.
> 
> Makes sense?

I saw that LauncherView and some unittests uses that method..

[Mr4D (OOO till 08-26), 2013-09-05 14:06:10]

lgtm.

You are right - I didn't see LauncherView.

[commit-bot: I haz the power, 2013-09-05 16:31:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23530020/1

[commit-bot: I haz the power, 2013-09-05 20:45:57]

Change committed as 221510