chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc - Issue 23530020: [cleanup] Remove LauncherItemChanged() from LauncherItemController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

Issue 23530020: [cleanup] Remove LauncherItemChanged() from LauncherItemController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

index 9b0bc44504f9787223b6c82471e8403813ac89f6..12467c444d7aa2c74d8676bcde9b0da7556ba40e 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

@@ -996,9 +996,6 @@ void ChromeLauncherController::LauncherItemMoved(int start_index,

void ChromeLauncherController::LauncherItemChanged(

int index,

const ash::LauncherItem& old_item) {

Mr4D (OOO till 08-26) 2013/09/04 03:47:02 You removed the LauncherItemChanged everywhere. Is

simonhong_ 2013/09/04 04:12:04 This is not needed in CLC. But I can't remove beca

Mr4D (OOO till 08-26) 2013/09/04 14:43:47 Right. But ... I was looking quickly over the 16 r

simonhong_ 2013/09/04 16:41:23 But.. LauncherItemMoved() is still needed by CLC.

- ash::LauncherID id = model_->items()[index].id;

- DCHECK(HasItemController(id));

- id_to_item_controller_map_[id]->LauncherItemChanged(index, old_item);

}

void ChromeLauncherController::LauncherStatusChanged() {