Disable click to select all for search terms

Disable click to select all for search terms

This CL disables click to select all when the omnibox is displaying
search terms. This makes it easier for users to edit search terms.
This is the Mac version of crrev.com/22972003.

BUG=225762
TEST=Enabled Instant Extended. Did a search from the omnibox.
Clicked on the search terms and verified that text was not
selected. Navigated to a URL. Clicked on the URL. Verified
that the URL was selected.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223637

[Robert Sesek, 2013-09-16 18:49:55]

LGTM. I was going to ask for a test for autocomplete_text_field.mm, but there
isn't one already :(.

[commit-bot: I haz the power, 2013-09-16 19:05:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23526044/3001

[commit-bot: I haz the power, 2013-09-16 19:05:56]

Failed to apply patch for
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
  Hunk #1 FAILED at 54.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h.rej

Patch:      
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
Index:
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
diff --git
a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
index
3ba6511a148c0450d1754ef6d09c16f9db69b998..e632672ffb5ffdcbf4eda02000ba97e4eae58071
100644
---
a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
+++
b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
@@ -54,6 +54,7 @@ class MockAutocompleteTextFieldObserver : public
AutocompleteTextFieldObserver {
   MOCK_METHOD0(OnKillFocus, void());
   MOCK_METHOD1(OnMouseDown, void(NSInteger button_number));
   MOCK_METHOD0(ShouldEnableCopyURL, bool());
+  MOCK_METHOD0(ShouldSelectAllOnMouseDown, bool());
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_AUTOCOMPLETE_TEXT_FIELD_UNITTEST_HELPER_H_

[commit-bot: I haz the power, 2013-09-16 23:02:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23526044/12001

[commit-bot: I haz the power, 2013-09-17 08:51:43]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-17 16:39:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23526044/12001

[commit-bot: I haz the power, 2013-09-17 18:18:44]

Change committed as 223637