chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm - Issue 23526044: Disable click to select all for search terms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

Issue 23526044: Disable click to select all for search terms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

index ee2dc0f032fe292ceee58001ec34bfc001625626..5150d6e47908d40f3030ab0c45525f816a149789 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

@@ -128,7 +128,8 @@

if (editor) {

NSEvent* currentEvent = [NSApp currentEvent];

if ([currentEvent type] == NSLeftMouseUp &&

- ![editor selectedRange].length) {

+ ![editor selectedRange].length &&

+ (!observer_ || observer_->ShouldSelectAllOnMouseDown())) {

[editor selectAll:nil];

}