Revert 157422 "Remove lots of code related synchronously attaching"

Revert 157422 "Remove lots of code related synchronously attaching"

Causing ASSERT failures in debug.

> Remove lots of code related synchronously attaching
> 
> Now that we always lazy attach we can remove the hacks and special
> cases related to synchronously attaching.
> 
> BUG=276689
> 
> Review URL: https://chromiumcodereview.appspot.com/23606020
> 
> git-svn-id: svn://svn.chromium.org/blink/trunk@157422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157431

[commit-bot: I haz the power, 2013-09-09 01:57:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/23526031/1

[esprehn, 2013-09-09 03:29:07]

On 2013/09/09 01:57:15, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/alancutter%40chromium.org/23526031/1

What assert failures? Do you have a stack trace or test? Some more detail when
rolling out would be nice.  :)

[dstockwell, 2013-09-09 03:35:07]

On 2013/09/09 03:29:07, esprehn wrote:
> On 2013/09/09 01:57:15, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >
https://chromium-status.appspot.com/cq/alancutter%2540chromium.org/23526031/1
> 
> What assert failures? Do you have a stack trace or test? Some more detail when
> rolling out would be nice.  :)

Here's a test log:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%...

eg.
16:49:48.520 18588   ASSERTION FAILED: document().inStyleRecalc()
16:49:48.520 18588   ../../third_party/WebKit/Source/core/dom/Node.cpp(1009) :
virtual void WebCore::Node::attach(const WebCore::Node::AttachContext&)

16:49:48.521 18588    [0x7fb97b030b16] WebCore::Node::attach()
16:49:48.522 18588    [0x7fb97af63950] WebCore::ContainerNode::attach()
16:49:48.522 18588    [0x7fb97af97494] WebCore::Document::attach()
16:49:48.522 18588    [0x7fb97bba5151] WebCore::DOMWindow::setDocument()
16:49:48.522 18588    [0x7fb97bb5145b]
WebCore::DocumentLoader::createWriterFor()
16:49:48.522 18588    [0x7fb97bb4f56f] WebCore::DocumentLoader::ensureWriter()
16:49:48.522 18588    [0x7fb97bb4f466] WebCore::DocumentLoader::ensureWriter()
16:49:48.522 18588    [0x7fb97bb4f672] WebCore::DocumentLoader::commitData()
16:49:48.522 18588    [0x7fb97bb4dc39]
WebCore::DocumentLoader::finishedLoading()
16:49:48.522 18588    [0x7fb97bb5087d] WebCore::DocumentLoader::maybeLoadEmpty()
16:49:48.522 18588    [0x7fb97bb509cb]
WebCore::DocumentLoader::startLoadingMainResource()
16:49:48.522 18588    [0x7fb97bb5c178] WebCore::FrameLoader::init()
16:49:48.522 18588    [0x7fb97a79195a] WebCore::Frame::init()
16:49:48.522 18588    [0x7fb97a78fcbc]
WebKit::WebFrameImpl::initializeAsMainFrame()
16:49:48.522 18588    [0x7fb97a7e3310]
WebKit::WebViewImpl::initializeMainFrame()
16:49:48.522 18588    [0x7fb9782dd5ca] content::RenderViewImpl::Initialize()
16:49:48.522 18588    [0x7fb9782df0f3] content::RenderViewImpl::Create()
16:49:48.522 18588    [0x7fb9782d3e86]
content::RenderThreadImpl::OnCreateNewView()
16:49:48.523 18588    [0x7fb9782d8a2f] DispatchToMethod<>()
16:49:48.523 18588    [0x7fb9782d707a] ViewMsg_New::Dispatch<>()
16:49:48.523 18588    [0x7fb9782d3a9c]
content::RenderThreadImpl::OnControlMessageReceived()
16:49:48.523 18588    [0x7fb977ecdfdf] content::ChildThread::OnMessageReceived()
16:49:48.523 18588    [0x7fb981029d8b]
IPC::ChannelProxy::Context::OnDispatchMessage()
16:49:48.523 18588    [0x7fb98102da9c] base::internal::RunnableAdapter<>::Run()
16:49:48.523 18588    [0x7fb98102d56c]
base::internal::InvokeHelper<>::MakeItSo()
16:49:48.523 18588    [0x7fb98102ce13] base::internal::Invoker<>::Run()
16:49:48.528 18588    [0x7fb97fb2e019] base::Callback<>::Run()
16:49:48.529 18588    [0x7fb97fb8fa1c] base::MessageLoop::RunTask()
16:49:48.529 18588    [0x7fb97fb8fb40]
base::MessageLoop::DeferOrRunPendingTask()
16:49:48.529 18588    [0x7fb97fb90065] base::MessageLoop::DoWork()
16:49:48.529 18588    [0x7fb97fb96bb4] base::MessagePumpDefault::Run()
16:49:48.529 18588    [0x7fb97fb8f5a9] base::MessageLoop::RunInternal()
16:49:48.529 18588    [0x7fb97fb8f4dc] base::MessageLoop::RunHandler()
16:49:48.529 18588    [0x7fb97fbce990] base::RunLoop::Run()
16:49:48.529 18588    [0x7fb97fb8ee64] base::MessageLoop::Run()
16:49:48.529 18588    [0x7fb97832b222] content::RendererMain()
16:49:48.529 18588    [0x7fb9779cbc39] content::RunZygote()
16:49:48.529 18588    [0x7fb9779cbe87] content::RunNamedProcessTypeMain()
16:49:48.529 18588    [0x7fb9779cd002] content::ContentMainRunnerImpl::Run()
16:49:48.529 18588    [0x7fb9779cb2c7] content::ContentMain()

[commit-bot: I haz the power, 2013-09-09 03:41:10]

Change committed as 157431