Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 23606020: Remove lots of code related synchronously attaching (Closed)

Created:
7 years, 3 months ago by esprehn
Modified:
7 years, 3 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove lots of code related synchronously attaching Now that we always lazy attach we can remove the hacks and special cases related to synchronously attaching. BUG=276689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157480

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix asserts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -40 lines) Patch
M Source/core/dom/Element.cpp View 1 4 chunks +3 lines, -15 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 3 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
esprehn
7 years, 3 months ago (2013-09-08 20:09:07 UTC) #1
eseidel
lgtm
7 years, 3 months ago (2013-09-08 22:21:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23606020/1
7 years, 3 months ago (2013-09-08 22:21:26 UTC) #3
ojan
https://codereview.chromium.org/23606020/diff/1/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (left): https://codereview.chromium.org/23606020/diff/1/Source/core/dom/Element.cpp#oldcode1359 Source/core/dom/Element.cpp:1359: if (document().inStyleRecalc()) Can we assert that we're in style ...
7 years, 3 months ago (2013-09-08 23:02:56 UTC) #4
commit-bot: I haz the power
Change committed as 157422
7 years, 3 months ago (2013-09-08 23:44:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23606020/16001
7 years, 3 months ago (2013-09-09 18:01:39 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=4739
7 years, 3 months ago (2013-09-09 19:47:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23606020/16001
7 years, 3 months ago (2013-09-09 20:15:04 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=4773
7 years, 3 months ago (2013-09-09 21:57:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23606020/16001
7 years, 3 months ago (2013-09-09 22:01:19 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 22:43:31 UTC) #11
Message was sent while issue was closed.
Change committed as 157480

Powered by Google App Engine
This is Rietveld 408576698