one-liners for the remaining top-50 dart:core classes

one-liners for the remaining top-50 dart:core classes

R=mcampione@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27496

[mem, 2013-09-13 15:51:21]

Kathy:

I'm not able to view side-by-side diffs in this one.
I can still do the review using the +/- view, but I wanted to let you know in
case this is a problem with the CL and will cause problems later when you try to
commit. It says "error old chunk mismatch".

mem

[mem, 2013-09-13 16:05:09]

A couple of small nits.
LGTM

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/iterator....
File sdk/lib/core/iterator.dart (right):

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/iterator....
sdk/lib/core/iterator.dart:11: * The [Iterator] is initially positioned before
the first element. Before
does it do it in this order? Test and get. Then maybe it should read ... "test
for the end of the iteration, and get the next item (or _element_) if there is
one.

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/regexp.dart
File sdk/lib/core/regexp.dart (right):

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/regexp.da...
sdk/lib/core/regexp.dart:10: * and iterates through the returned iterable of
[Match] objects.
Reverse to rid ourselves of passive voice?

[Pattern] matching methods return a Match or an [Iterable] of Match objects.

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (left):

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/set.dart#...
sdk/lib/core/set.dart:10: 
[Element] type?

Or delete "of the element type". What does that mean?

Hard to know what this means without the context of the rest of the file.

https://chromiumcodereview.appspot.com/23522037/diff/1/sdk/lib/core/set.dart#...
sdk/lib/core/set.dart:13: 
elements -> objects

[Kathy Walrath, 2013-09-13 18:41:08]

Committed patchset #3 manually as r27496 (presubmit successful).

[Lasse Reichstein Nielsen, 2016-08-31 18:57:36]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-08-31 18:57:37]

Late comments

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/iterator.dart
File sdk/lib/core/iterator.dart (right):

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/iterator.dar...
sdk/lib/core/iterator.dart:10: * The for-in construct transparently uses
Iterator to test for the end
`Iterator`

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/iterator.dar...
sdk/lib/core/iterator.dart:21: * A typical usage of an Iterator looks as
follows:
`Iterator`

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/object.dart
File sdk/lib/core/object.dart (right):

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/object.dart#...
sdk/lib/core/object.dart:10: * Because Object is the root of the Dart class
hierarchy,
`Object`

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/regexp.dart
File sdk/lib/core/regexp.dart (right):

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/regexp.dart#...
sdk/lib/core/regexp.dart:10: * A Match or an [Iterable] of Match objects is
returned from [Pattern]
`Match` *2

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (right):

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/set.dart#new...
sdk/lib/core/set.dart:11: * to be in the set, or to _not_ be in the set.
Trailing space, please remove.

[Kathy Walrath, 2016-08-31 20:36:08]

I forgot all about this. Obviously. :)

We used to intentionally not code-font class names (especially in API docs,
which we wanted to make as easy to write as possible), but that doesn't seem to
be the style people have adopted.

[kevmoo, 2016-08-31 21:07:51]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-08-31 21:07:52]

DBC

https in URLs makes puppies happy

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/core.dart
File sdk/lib/core/core.dart (right):

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/core.dart#ne...
sdk/lib/core/core.dart:150: * [Dart Language
Specification](http://www.dartlang.org/docs/spec/)
https, please

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/iterator.dart
File sdk/lib/core/iterator.dart (right):

https://codereview.chromium.org/23522037/diff/19001/sdk/lib/core/iterator.dar...
sdk/lib/core/iterator.dart:29: *
(http://www.dartlang.org/docs/dart-up-and-running/contents/ch03.html#ch03-iter...)
https please

[Lasse Reichstein Nielsen, 2016-09-01 05:29:36]

On 2016/08/31 20:36:08, Kathy Walrath wrote:
> I forgot all about this. Obviously. :)
> 
> We used to intentionally not code-font class names (especially in API docs,
> which we wanted to make as easy to write as possible), but that doesn't seem
to
> be the style people have adopted.

Indeed. I prefer to use code-font for "proper names" referring to code
declarations.
I'll write, say, "iterable" without code quotes and `Iterable` (captalized) with
code quotes. There might not be a real difference between the two concepts, but
I find a non-code "Iterable" to be confusing - is it trying to be general or is
it referring to the class?