Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 23522025: InstantExtended: add a finch flag to disable Instant Extended on SRP. (Closed)

Created:
7 years, 3 months ago by samarth
Modified:
7 years, 3 months ago
Reviewers:
David Black, Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Visibility:
Public.

Description

InstantExtended: add a finch flag to disable Instant Extended on SRP. BUG=286446 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221885

Patch Set 1 #

Patch Set 2 : Use finch flag. Dont put in Instant process. #

Patch Set 3 : Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -7 lines) Patch
M chrome/browser/search/search.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/search/search.cc View 1 5 chunks +24 lines, -7 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 2 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
samarth
Please review. (I'm bringing up a server to test against. 3 is currently ignored.) We ...
7 years, 3 months ago (2013-09-06 21:05:42 UTC) #1
samarth
Per offline discussion, I'll split this into a finch flag and a "special" espv value.
7 years, 3 months ago (2013-09-06 21:18:51 UTC) #2
samarth
+pkasting FYI Ok, take a look now. I also made it so that the SRP ...
7 years, 3 months ago (2013-09-06 21:58:09 UTC) #3
Jered
On 2013/09/06 21:58:09, samarth wrote: > +pkasting FYI > > Ok, take a look now. ...
7 years, 3 months ago (2013-09-06 22:11:11 UTC) #4
Peter Kasting
On 2013/09/06 21:58:09, samarth wrote: > +pkasting FYI This won't impact me, so feel free ...
7 years, 3 months ago (2013-09-06 22:26:51 UTC) #5
David Black
lgtm
7 years, 3 months ago (2013-09-07 00:55:29 UTC) #6
samarth
Thanks, added tests. Samarth
7 years, 3 months ago (2013-09-07 01:29:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samarth@chromium.org/23522025/9001
7 years, 3 months ago (2013-09-07 01:30:17 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 04:19:05 UTC) #9
Message was sent while issue was closed.
Change committed as 221885

Powered by Google App Engine
This is Rietveld 408576698