InstantExtended: add a finch flag to disable Instant Extended on SRP.

chrome/browser/search/search_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_base.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/prefs/pref_service.h"
@@ skipping 206 matching lines @@
       "InstantExtended", "Controll1 hide_verbatim:1"));
   EXPECT_TRUE(ShouldHideTopVerbatimMatch());
 }
 
 TEST_F(ShouldHideTopVerbatimTest, DisableByFlag) {
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       "InstantExtended", "Group1 hide_verbatim:0"));
   EXPECT_FALSE(ShouldHideTopVerbatimMatch());
 }
 
+typedef InstantExtendedAPIEnabledTest ShouldSuppressInstantExtendedOnSRPTest;
+
+TEST_F(ShouldSuppressInstantExtendedOnSRPTest, NotSet) {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      "InstantExtended", "Group1 espv:2"));
+  EXPECT_FALSE(ShouldSuppressInstantExtendedOnSRP());
+  EXPECT_TRUE(IsInstantExtendedAPIEnabled());
+  EXPECT_TRUE(IsQueryExtractionEnabled());
+  EXPECT_EQ(2ul, EmbeddedSearchPageVersion());
+}
+
+TEST_F(ShouldSuppressInstantExtendedOnSRPTest, NotSuppressOnSRP) {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      "InstantExtended", "Group1 espv:2 suppress_on_srp:0"));
+  EXPECT_FALSE(ShouldSuppressInstantExtendedOnSRP());
+  EXPECT_TRUE(IsInstantExtendedAPIEnabled());
+  EXPECT_TRUE(IsQueryExtractionEnabled());
+  EXPECT_EQ(2ul, EmbeddedSearchPageVersion());
+}
+
+TEST_F(ShouldSuppressInstantExtendedOnSRPTest, SuppressOnSRP) {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      "InstantExtended", "Group1 espv:2 suppress_on_srp:1"));
+  EXPECT_TRUE(ShouldSuppressInstantExtendedOnSRP());
+  EXPECT_TRUE(IsInstantExtendedAPIEnabled());
+  EXPECT_FALSE(IsQueryExtractionEnabled());
+  EXPECT_EQ(2ul, EmbeddedSearchPageVersion());
+}
+
 class SearchTest : public BrowserWithTestWindowTest {
  protected:
   virtual void SetUp() OVERRIDE {
     BrowserWithTestWindowTest::SetUp();
     field_trial_list_.reset(new base::FieldTrialList(
         new metrics::SHA1EntropyProvider("42")));
     TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
         profile(), &TemplateURLServiceFactory::BuildInstanceFor);
     TemplateURLService* template_url_service =
         TemplateURLServiceFactory::GetForProfile(profile());
@@ skipping 108 matching lines @@
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     const SearchTestCase& test = kTestCases[i];
     EXPECT_EQ(test.expected_result,
               ShouldAssignURLToInstantRenderer(GURL(test.url), profile()))
         << test.url << " " << test.comment;
   }
 }
 
+TEST_F(SearchTest, ShouldAssignURLToInstantRendererExtendedEnabledNotOnSRP) {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      "InstantExtended", "Group1 espv:2 suppress_on_srp:1"));
+
+  const SearchTestCase kTestCases[] = {
+    {chrome::kChromeSearchLocalNtpUrl, true,  ""},
+    {"https://foo.com/instant?strk",   true,  ""},
+    {"https://foo.com/instant#strk",   true,  ""},
+    {"https://foo.com/instant?strk=0", true,  ""},
+    {"https://foo.com/url?strk",       false, "Disabled on SRP"},
+    {"https://foo.com/alt?strk",       false, "Disabled ON SRP"},
+    {"http://foo.com/instant",         false, "Non-HTTPS"},
+    {"http://foo.com/instant?strk",    false, "Non-HTTPS"},
+    {"http://foo.com/instant?strk=1",  false, "Non-HTTPS"},
+    {"https://foo.com/instant",        false, "No search terms replacement"},
+    {"https://foo.com/?strk",          false, "Non-exact path"},
+  };
+
+  for (size_t i = 0; i < arraysize(kTestCases); ++i) {
+    const SearchTestCase& test = kTestCases[i];
+    EXPECT_EQ(test.expected_result,
+              ShouldAssignURLToInstantRenderer(GURL(test.url), profile()))
+        << test.url << " " << test.comment;
+  }
+}
+
 TEST_F(SearchTest, ShouldUseProcessPerSiteForInstantURL) {
   EnableInstantExtendedAPIForTesting();
 
   const SearchTestCase kTestCases[] = {
     {"chrome-search://local-ntp",      true,  "Local NTP"},
     {"chrome-search://online-ntp",     true,  "Online NTP"},
     {"invalid-scheme://local-ntp",     false, "Invalid Local NTP URL"},
     {"invalid-scheme://online-ntp",    false, "Invalid Online NTP URL"},
     {"chrome-search://foo.com",        false, "Search result page"},
     {"https://foo.com/instant?strk",   false,  ""},
@@ skipping 350 matching lines @@
   EXPECT_TRUE(chrome::IsNTPURL(search_url_without_search_terms, profile()));
 
   EXPECT_FALSE(chrome::IsNTPURL(ntp_url, NULL));
   EXPECT_FALSE(chrome::IsNTPURL(local_ntp_url, NULL));
   EXPECT_FALSE(chrome::IsNTPURL(remote_ntp_url, NULL));
   EXPECT_FALSE(chrome::IsNTPURL(search_url_with_search_terms, NULL));
   EXPECT_FALSE(chrome::IsNTPURL(search_url_without_search_terms, NULL));
 }
 
 }  // namespace chrome