Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23516012: Rename StyleSheetCollections to StyleEngine. (Closed)

Created:
7 years, 3 months ago by dglazkov
Modified:
7 years, 3 months ago
CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, gavinp+prerender_chromium.org, eustas+blink_chromium.org, webcomponents-bugzilla_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, loislo+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Rename StyleSheetCollections to StyleEngine. This will be the new state/controller for everything related to style resolution. BUG=291287 R=abarth, eae, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -770 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/DocumentRuleSets.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/DocumentRuleSets.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleSheetList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 12 chunks +21 lines, -21 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/StyleElement.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/dom/StyleEngine.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + Source/core/dom/StyleEngine.cpp View 21 chunks +29 lines, -29 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/dom/StyleSheetCollections.h View 1 chunk +0 lines, -163 lines 0 comments Download
D Source/core/dom/StyleSheetCollections.cpp View 1 chunk +0 lines, -458 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLQuoteElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PageGroup.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBR.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDocument.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dglazkov
7 years, 3 months ago (2013-09-13 22:57:16 UTC) #1
eae
LGTM
7 years, 3 months ago (2013-09-16 15:41:26 UTC) #2
eseidel
I love it when you have coding days. :)
7 years, 3 months ago (2013-09-16 16:38:01 UTC) #3
dglazkov
On 2013/09/16 16:38:01, eseidel wrote: > I love it when you have coding days. :) ...
7 years, 3 months ago (2013-09-16 16:43:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/23516012/1
7 years, 3 months ago (2013-09-16 17:12:32 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 18:06:39 UTC) #6
Message was sent while issue was closed. 
Change committed as 157837

Powered by Google App Engine
This is Rietveld 408576698