Only check if setup wizard is disabled if doing provision check.

Only check if setup wizard is disabled if doing provision check.

The provision check checks if setup wizard is disabled. If the device status
check is run with no-provision-check, don't try to get read the status of the
setup wizard from the device.

The reason for the change is that checking the status of the setup wizard has
caused problems in certain cases (see the discussion on the bug). While the
particular issue can be fixed elsewhere, it is better to not check the status if
we are not going to use it.

BUG=255157
TBR=ilevy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220696

[navabi, 2013-08-30 01:41:24]

On 2013/08/30 01:30:43, navabi wrote:

Wait! Don't review yet. I'm going to take the assert out of android_commands.py
too. If an un-provisioned device has the ro.setupwizard.mode empty when not
disabled, we should not assert that it is non-empty.

[navabi, 2013-08-30 01:44:54]

On 2013/08/30 01:41:24, navabi wrote:
> On 2013/08/30 01:30:43, navabi wrote:
> 
> Wait! Don't review yet. I'm going to take the assert out of
android_commands.py
> too. If an un-provisioned device has the ro.setupwizard.mode empty when not
> disabled, we should not assert that it is non-empty.

Ok. PTAL.

[mkosiba (inactive), 2013-08-30 13:13:33]

LGTM

https://codereview.chromium.org/23503015/diff/5001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_status_check.py (left):

https://codereview.chromium.org/23503015/diff/5001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_status_check.py:44: setup_wizard_disabled =
device_adb.GetSetupWizardStatus() == 'DISABLED'
if you've taken the assert out in GetSetupWizardStatus then you could just
change it to say != 'ENABLED', right?

[mkosiba (inactive), 2013-08-30 13:13:33]

LGTM

https://codereview.chromium.org/23503015/diff/5001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_status_check.py (left):

https://codereview.chromium.org/23503015/diff/5001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_status_check.py:44: setup_wizard_disabled =
device_adb.GetSetupWizardStatus() == 'DISABLED'
if you've taken the assert out in GetSetupWizardStatus then you could just
change it to say != 'ENABLED', right?

[navabi, 2013-08-30 15:53:10]

https://codereview.chromium.org/23503015/diff/5001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_status_check.py (left):

https://codereview.chromium.org/23503015/diff/5001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_status_check.py:44: setup_wizard_disabled =
device_adb.GetSetupWizardStatus() == 'DISABLED'
On 2013/08/30 13:13:33, mkosiba wrote:
> if you've taken the assert out in GetSetupWizardStatus then you could just
> change it to say != 'ENABLED', right?

That would work too. But we would still be checking the property on the device
and then not using it. Let's say we have a new device that doesn't have that
property (or the name of the property changed).

While we would also need to fix it other places (e.g. android_commands.py), if
we didn't care about it anyway, we could at least run device status check
without having to worry about that property.

[commit-bot: I haz the power, 2013-08-30 16:21:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/23503015/5001

[commit-bot: I haz the power, 2013-08-30 16:30:24]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[navabi, 2013-08-30 17:54:16]

On 2013/08/30 16:30:24, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Need LGTM from owner.

[commit-bot: I haz the power, 2013-08-30 17:58:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/23503015/5001

[frankf, 2013-08-30 18:35:19]

lgtm

[commit-bot: I haz the power, 2013-08-30 23:36:55]

Change committed as 220696