Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2949)

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 23503015: Only check if setup wizard is disabled if doing provision check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Take out assert from android_commands.py. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/android_commands.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_status_check.py
diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py
index ae0bb4a7b18b1aed4be9c850c78651166b296bee..9ce2b82a21f0861eba5e04395ddd880e49254367 100755
--- a/build/android/buildbot/bb_device_status_check.py
+++ b/build/android/buildbot/bb_device_status_check.py
@@ -41,7 +41,6 @@ def DeviceInfo(serial, options):
device_build_type = device_adb.GetBuildType()
device_product_name = device_adb.GetProductName()
- setup_wizard_disabled = device_adb.GetSetupWizardStatus() == 'DISABLED'
mkosiba (inactive) 2013/08/30 13:13:33 if you've taken the assert out in GetSetupWizardSt
navabi 2013/08/30 15:53:10 That would work too. But we would still be checkin
battery = device_adb.GetBatteryInfo()
install_output = GetCmdOutput(
['%s/build/android/adb_install_apk.py' % constants.DIR_SOURCE_ROOT, '--apk',
@@ -76,9 +75,10 @@ def DeviceInfo(serial, options):
errors = []
if battery_level < 15:
errors += ['Device critically low in battery. Turning off device.']
- if (not setup_wizard_disabled and device_build_type != 'user' and
- not options.no_provisioning_check):
- errors += ['Setup wizard not disabled. Was it provisioned correctly?']
+ if not options.no_provisioning_check:
+ setup_wizard_disabled = device_adb.GetSetupWizardStatus() == 'DISABLED'
+ if not setup_wizard_disabled and device_build_type != 'user':
+ errors += ['Setup wizard not disabled. Was it provisioned correctly?']
if device_product_name == 'mantaray' and ac_power != 'true':
errors += ['Mantaray device not connected to AC power.']
# TODO(navabi): Insert warning once we have a better handle of what install
« no previous file with comments | « no previous file | build/android/pylib/android_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698