Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23498031: Move code related to the window controls to ash/wm/caption_buttons (Closed)

Created:
7 years, 3 months ago by pkotwicz
Modified:
7 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Move code related to the window controls to ash/wm/caption_buttons BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223309

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2965 lines) Patch
M ash/ash.gyp View 1 5 chunks +10 lines, -10 lines 0 comments Download
A + ash/wm/caption_buttons/alternate_frame_caption_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/caption_buttons/alternate_frame_caption_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/caption_buttons/frame_caption_button_container_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/wm/caption_buttons/frame_caption_button_container_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/caption_buttons/frame_maximize_button.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/wm/caption_buttons/frame_maximize_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/wm/caption_buttons/maximize_bubble_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/wm/caption_buttons/maximize_bubble_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/caption_buttons/maximize_bubble_frame_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/custom_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/custom_frame_view_ash_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/frame_painter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/frame_painter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/maximize_bubble_controller.h View 1 chunk +0 lines, -101 lines 0 comments Download
D ash/wm/maximize_bubble_controller.cc View 1 1 chunk +0 lines, -864 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/workspace/alternate_frame_caption_button.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ash/wm/workspace/alternate_frame_caption_button.cc View 1 chunk +0 lines, -230 lines 0 comments Download
D ash/wm/workspace/frame_caption_button_container_view.h View 1 chunk +0 lines, -149 lines 0 comments Download
D ash/wm/workspace/frame_caption_button_container_view.cc View 1 chunk +0 lines, -358 lines 0 comments Download
D ash/wm/workspace/frame_caption_button_container_view_unittest.cc View 1 chunk +0 lines, -325 lines 0 comments Download
D ash/wm/workspace/frame_maximize_button.h View 1 chunk +0 lines, -183 lines 0 comments Download
D ash/wm/workspace/frame_maximize_button.cc View 1 chunk +0 lines, -619 lines 0 comments Download
D ash/wm/workspace/maximize_bubble_frame_state.h View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
James, PTAL I am unfortunately going to be adding more classes related to the window ...
7 years, 3 months ago (2013-09-13 02:22:50 UTC) #1
James Cook
lgtm, sorry for the delay
7 years, 3 months ago (2013-09-13 18:35:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/23498031/13001
7 years, 3 months ago (2013-09-15 17:21:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79147
7 years, 3 months ago (2013-09-15 23:46:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/23498031/13001
7 years, 3 months ago (2013-09-16 02:42:49 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 03:24:36 UTC) #6
Message was sent while issue was closed. 
Change committed as 223309

Powered by Google App Engine
This is Rietveld 408576698