Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 23496028: Disable DNS probes on Android. (Closed)

Created:
7 years, 3 months ago by Deprecated (see juliatuttle)
Modified:
7 years, 3 months ago
Reviewers:
Nico, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable DNS probes on Android. There are a couple of bugs in DNS probes on Android (we don't register the NetErrorTabHelper, and the system probes don't work, so the results are kind of wonky). Disable them until we can fix them properly. BUG=156415 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222305

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/net/net_error_info.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mmenke
LGTM
7 years, 3 months ago (2013-09-05 17:36:58 UTC) #1
Deprecated (see juliatuttle)
PTAL, jhawkins (for OWNERS review).
7 years, 3 months ago (2013-09-05 17:53:34 UTC) #2
Deprecated (see juliatuttle)
PTAL, thakis (for OWNERS review).
7 years, 3 months ago (2013-09-09 19:54:38 UTC) #3
Nico
lgtm
7 years, 3 months ago (2013-09-09 20:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/23496028/9001
7 years, 3 months ago (2013-09-09 20:31:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=77036
7 years, 3 months ago (2013-09-10 05:59:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/23496028/9001
7 years, 3 months ago (2013-09-10 16:57:25 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 17:55:07 UTC) #8
Message was sent while issue was closed.
Change committed as 222305

Powered by Google App Engine
This is Rietveld 408576698