Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 23484061: Print gsutil error message when we enconter as 403 or 404 (Closed)

Created:
7 years, 3 months ago by Ryan Tseng
Modified:
7 years, 3 months ago
Reviewers:
Isaac (away), iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, kjellander_chromium
Visibility:
Public.

Description

Print gsutil error message when we enconter as 403 or 404 We appear to be getting 403's when encountering errors other than mismatched credentials. The error message was originally hidden to avoid clutter, but it has become obvious that there are other transient errors hidden behind a 403. This change prints the original gsutil error message regardless of whether or not we enconter a 403 or 404. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=224195

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M download_from_google_storage.py View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Tseng
7 years, 3 months ago (2013-09-19 17:53:34 UTC) #1
Isaac (away)
lgtm, thanks! https://codereview.chromium.org/23484061/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/23484061/diff/1/download_from_google_storage.py#newcode90 download_from_google_storage.py:90: print >> sys.stderr, ls_err Optional nit: consider ...
7 years, 3 months ago (2013-09-19 17:57:59 UTC) #2
Ryan Tseng
https://codereview.chromium.org/23484061/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/23484061/diff/1/download_from_google_storage.py#newcode90 download_from_google_storage.py:90: print >> sys.stderr, ls_err On 2013/09/19 17:57:59, Isaac wrote: ...
7 years, 3 months ago (2013-09-19 18:05:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/23484061/1
7 years, 3 months ago (2013-09-19 18:06:41 UTC) #4
commit-bot: I haz the power
Presubmit check for 23484061-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 3 months ago (2013-09-19 18:09:44 UTC) #5
Ryan Tseng
+iannucci: Can I get an OWNERS stamp from you? :)
7 years, 3 months ago (2013-09-19 18:15:08 UTC) #6
iannucci
lgtm
7 years, 3 months ago (2013-09-19 18:59:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/23484061/1
7 years, 3 months ago (2013-09-19 19:58:39 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 20:00:53 UTC) #9
Message was sent while issue was closed.
Change committed as 224195

Powered by Google App Engine
This is Rietveld 408576698