Print gsutil error message when we enconter as 403 or 404

download_from_google_storage.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Download files from Google Storage based on SHA1 sums."""
 
 
 import hashlib
 import optparse
@@ skipping 68 matching lines @@
     return (code, out, err)
 
 
 def check_bucket_permissions(bucket, gsutil):
   if not bucket:
     print >> sys.stderr, 'Missing bucket %s.'
     return (None, 1)
   base_url = 'gs://%s' % bucket
 
   code, _, ls_err = gsutil.check_call('ls', base_url)
+  if code != 0:
+    print >> sys.stderr, ls_err

[Isaac (away), 2013/09/19 17:57:59]

Optional nit: consider wrapping this so it's clear where the text is coming
from, perhaps:

'gsutil: "%s"' % ls_err

Though gsutil already does a pretty good just of informative output, for
example:
GSResponseError: status=403, code=RequestTimeTooSkewed, reason=Forbidden

[Ryan Tseng, 2013/09/19 18:05:51]

Yeah I think gsutil already does a pretty good job, no need to add any more
colons

$ download_from_google_storage . -b chsihd-dhef -dr                             
                                                                                
      
GSResponseError: status=404, code=NoSuchBucket, reason=Not Found.

gs://chsihd-dhef not found.

vs.

mudkip(er) ~/Documents/depot_tools$ download_from_google_storage . -b
chsihd-dhef -dr
gsutil: GSResponseError: status=404, code=NoSuchBucket, reason=Not Found.

gs://chsihd-dhef not found.

   if code == 403:
     print >> sys.stderr, 'Got error 403 while authenticating to %s.' % base_url
     print >> sys.stderr, 'Try running "download_from_google_storage --config".'
   elif code == 404:
     print >> sys.stderr, '%s not found.' % base_url
-  elif code != 0:
-    print >> sys.stderr, ls_err
   return (base_url, code)
 
 
 def get_sha1(filename):
   sha1 = hashlib.sha1()
   with open(filename, 'rb') as f:
     while True:
       # Read in 1mb chunks, so it doesn't all have to be loaded into memory.
       chunk = f.read(1024*1024)
       if not chunk:
@@ skipping 237 matching lines @@
     return code
 
   return download_from_google_storage(
       input_filename, base_url, gsutil, options.num_threads, options.directory,
       options.recursive, options.force, options.output, options.ignore_errors,
       options.sha1_file)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))