Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 23484041: Split filename-based syscall implementations into a separate file (Closed)

Created:
7 years, 3 months ago by Mark Seaborn
Modified:
7 years, 3 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Split filename-based syscall implementations into a separate file Create sys_filename.c, split out from nacl_syscall_common.c. This is for syscalls that take filenames as arguments, all of which are only enabled in debug mode. This naming matches the "irt_filename" interface. This is intended to make nacl_syscall_common.c more manageable -- currently it's quite large. Add missing #include to nacl_host_desc.h so that the nacl_host_stat_t type it defines is usable. BUG=none TEST=build Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12154

Patch Set 1 #

Patch Set 2 : Fix missing #includes for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -356 lines) Patch
M src/shared/platform/nacl_host_desc.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/build.scons View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.h View 3 chunks +0 lines, -34 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.c View 1 5 chunks +1 line, -322 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_handlers_gen.py View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/service_runtime/sys_filename.h View 1 chunk +55 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/sys_filename.c View 1 chunk +341 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
7 years, 3 months ago (2013-09-12 20:15:22 UTC) #1
bradn
lgtm
7 years, 3 months ago (2013-09-12 21:38:15 UTC) #2
Mark Seaborn
7 years, 3 months ago (2013-09-12 23:01:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r12154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698