Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 23484032: Shadow DOM: Move handleDOMActivateEvent back from InputTypeView to InputType. (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, abarth-chromium
Visibility:
Public.

Description

Shadow DOM: Move handleDOMActivateEvent back from InputTypeView to InputType. This affects input[type=color], input[type=file], input[type=image], input[type=reset], and input[type=submit]. Without this change, web authors have no ways to open a file chooser dialog. We exclude BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent, Date/time input types on Android, because of consistency with non-Android ports, which don't respond to DOMActivate. Also, this CL makes it possible to test if a file chooser is opened. BUG=274205 TEST=automated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157648

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M LayoutTests/accessibility/file-upload-button-with-axpress-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadowdom-for-input-file.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadowdom-for-input-file-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/BaseChooserOnlyDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/InputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/InputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/forms/InputTypeView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/InputTypeView.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/testing/runner/WebTestProxy.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M public/testing/WebTestProxy.h View 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 3 months ago (2013-09-11 06:54:03 UTC) #1
keishi
lgtm
7 years, 3 months ago (2013-09-12 01:23:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23484032/10001
7 years, 3 months ago (2013-09-12 01:25:37 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 01:31:04 UTC) #4
Message was sent while issue was closed.
Change committed as 157648

Powered by Google App Engine
This is Rietveld 408576698