Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 23484022: DumpWithoutCrashing() is looking up wrong breakpad_win entry point. (Closed)

Created:
7 years, 3 months ago by Roger McFarlane (Chromium)
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

DumpWithoutCrashing() is looking up wrong breakpad_win entry point. DumpWithoutCrashing() was looking up DumpProcess instead of DumpProcessWithoutCrash. The former generates a dialog to restart chrome while the latter does not. Neither actually crashes the browser process. Prior to the CL, anything invoking DumpWithoutCrashing() would appear to the user as if a crash had occurred, allowing the user to start a new browser process/window, but leaving the original up and running (unless the caller subsequently crashed the browser itself). R= rtenneti@chromium.org, mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/dump_without_crashing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
lgtm thanks for the finding the bug and fixing it.
7 years, 3 months ago (2013-09-09 18:31:34 UTC) #1
Roger McFarlane (Chromium)
+jam for OWNERS
7 years, 3 months ago (2013-09-09 20:14:19 UTC) #2
jam
lgtm
7 years, 3 months ago (2013-09-09 20:42:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerm@chromium.org/23484022/1
7 years, 3 months ago (2013-09-10 13:09:42 UTC) #4
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
7 years, 3 months ago (2013-09-10 16:11:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerm@chromium.org/23484022/1
7 years, 3 months ago (2013-09-10 21:40:22 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 23:25:23 UTC) #7
Message was sent while issue was closed.
Change committed as 222393

Powered by Google App Engine
This is Rietveld 408576698