Issue 23484021: Implement SendSuspendImminent() and SendSuspendStateChanged() of FakePowerManagerClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23484021: Implement SendSuspendImminent() and SendSuspendStateChanged() of FakePowerManagerClient. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement SendSuspendImminent() and SendSuspendStateChanged() of FakePowerManagerClient. Observer's callback SuspendImminent() and SystemResumed() are used by MountedDiskMonitor. Focusing on the usage, this CL adds two methods SendSuspendImminent() and SendSuspendStateChanged() emulating DBus's signals for testing purpose. These methods will be used in tests of a following CL. BUG=279276 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222525

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -4 lines)			Patch
	M	chromeos/dbus/fake_power_manager_client.h	View		2 chunks	+15 lines, -1 line	0 comments	Download
	M	chromeos/dbus/fake_power_manager_client.cc	View		2 chunks	+24 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hidehiko

On 2013/09/09 18:10:52, hidehiko wrote: > Thank you for your review in advance, > - ...

7 years, 3 months ago (2013-09-11 01:03:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23484021/1

7 years, 3 months ago (2013-09-11 10:07:20 UTC) #4

Message was sent while issue was closed.

Change committed as 222525

Expand Messages | Collapse Messages